-
Notifications
You must be signed in to change notification settings - Fork 64
Add Azure Language Services provider #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@psorensen thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
1239c7d to
55bca24
Compare
|
@dkotter How should I handle the VIP flag for |
So we've not been consistent with this so far in the codebase. We've basically done both, where we use Personally I'd prefer we go with the first approach, as this is technically a VIP approved plugin so it's nice to match their standards. We have had issues though a few times with timeouts, as some of these services take a bit to return. |
1bac627 to
b550389
Compare
|
sounds good @dkotter - I've included a helper function to facilitate a refactor of all the existing usage of |
|
@psorensen is this still WIP or can this formally go through review/merge? |
…ion settings Hide prompt and length fields when Azure Language provider is selected since it uses predefined string options for these settings.
b05cf8d to
cf867a2
Compare
cf867a2 to
4139791
Compare
|
@dkotter @Sidsector9 back to you for review |
Description of the Change
This PR adds Azure Language Services as a provider and adds it to the Excerpt Generation feature.
Closes #159
How to test the Change
Testing Steps:
Changelog Entry
Credits
Props @psorensen @cadic @jeffpaul @Sidsector9 @dkotter
Checklist: