Make the response object testable.

Author: alistairjevans

Cargo.lock

@@ -19,4 +19,5 @@ rb-sys = "0.9.110"
 hyper = { version = "1.0", features = ["http1", "http2", "server"] }
 hyper-util = { version = "0.1", features = ["tokio", "server", "http1", "http2"] }
 http-body-util = "0.1.2"
-jemallocator = { version = "0.5.4", features = ["disable_initial_exec_tls"] }
+jemallocator = { version = "0.5.4", features = ["disable_initial_exec_tls"] }
+futures = "0.3.31"

ext/hyper_ruby/Cargo.toml

@@ -2,13 +2,11 @@ mod request;
 mod response;
 mod gvl_helpers;
 
-use hyper::header::HeaderName;
 use request::Request;
 use response::Response;
 use gvl_helpers::nogvl;
 
 use magnus::block::block_proc;
-use magnus::r_hash::ForEach;
 use magnus::typed_data::Obj;
 use magnus::{function, method, prelude::*, Error as MagnusError, IntoValue, Ruby, Value};
 use bytes::Bytes;
@@ -298,6 +296,9 @@ fn init(ruby: &Ruby) -> Result<(), MagnusError> {
 
     let response_class = module.define_class("Response", ruby.class_object())?;
     response_class.define_singleton_method("new", function!(Response::new, 3))?;
+    response_class.define_method("status", method!(Response::status, 0))?;
+    response_class.define_method("headers", method!(Response::headers, 0))?;
+    response_class.define_method("body", method!(Response::body, 0))?;
 
     let request_class = module.define_class("Request", ruby.class_object())?;
     request_class.define_method("http_method", method!(Request::method, 0))?;

ext/hyper_ruby/src/lib.rs

@@ -1,8 +1,10 @@
+use futures::FutureExt;
 use magnus::{r_hash::ForEach, wrap, RHash, RString, Error as MagnusError};
 
-use hyper::{header::HeaderName, Response as HyperResponse, StatusCode};
-use http_body_util::Full;
+use hyper::{header::HeaderName, Response as HyperResponse};
+use http_body_util::{BodyExt, Full};
 use bytes::Bytes;
+
 // Response object returned to Ruby; holds reference to the opaque ruby types for the headers and body.
 #[wrap(class = "HyperRuby::Response")]
 pub struct Response {
@@ -38,4 +40,27 @@ impl Response {
             }
         }
     }
+
+    pub fn status(&self) -> u16 {
+        self.response.status().into()
+    }
+
+    pub fn headers(&self) -> RHash {
+        // map back from the hyper headers to the ruby hash; doesn't need to be performant,
+        // only used in tests
+        let headers = RHash::new();
+        for (name, value) in self.response.headers() {
+            headers.aset(name.to_string(), value.to_str().unwrap().to_string()).unwrap();
+        }
+        headers
+    }
+
+    pub fn body(&self) -> RString {
+        // copy back from the hyper body to the ruby string; doesn't need to be performant,
+        // only used in tests
+        let body = self.response.body();
+        let frame = body.clone().frame().now_or_never().unwrap().unwrap().unwrap();
+        let data_chunk = frame.into_data().unwrap();
+        RString::from_slice(data_chunk.iter().as_slice())
+    }
 }

ext/hyper_ruby/src/response.rs

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require "test_helper"
+require "httpx"
+
+class TestHyperRuby < Minitest::Test
+
+  def test_can_read_properties_back
+    response = HyperRuby::Response.new(200, { 'Content-Type' => 'text/plain' }, 'Hello, world!')
+    assert_equal 200, response.status
+    assert_equal 'text/plain', response.headers['content-type']
+    assert_equal 'Hello, world!', response.body
+  end
+
+end