WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

DataArrayProxy converting dimensions from double to size_t from JSON #414

@JDuffeyBQ

Description

@JDuffeyBQ

In DataArrayProxy::readVector, an array of numbers is read from JSON and converted to a std::vector<size_t>. This function is used to read the tuple and component dimensions from JSON. This function does some checks on the range of acceptable values; however, it does not report any errors and has an implicit conversion between double and size_t inside its check. For exceedingly large datasets this would be an issue when attempting to read and write their dimensions.

A possible solution would be to store the dimensions as a string though this would affect backwards compatibility in pipeline files. Additionally better error reporting should be implemented to tell the user why the read failed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions