build_image should not push images when build_and_push_image exists

[toast-gear]

Orb version

circleci/aws-ecr@9.7.0

What happened

The orb contains 2 methods relating directly to building images:

build_and_push_image
build_image

Expected behavior

I would expect build_and_push_image by default to build an image and push it and build_image by default to build an image and not push it or what's the point of it existing

[marboledacci]

Hi @toast-gear the difference here can be very confusing, and the naming is definitely not the best. But to make it clear, the build_image is a basic command that only takes care of the docker command. Whereas build_and_push_image may include steps like, checking out the repo, and authenticating to aws.

[toast-gear]

I see, the names are very confusing imo and don't really indicate the above