WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@rdesgroppes
Copy link
Contributor

Cherry-picked from #43773.

What does this PR do?

Add GOCACHE isolation to TestAll in pkg/linters/components/pkgconfigusage to reduce test timeouts on macOS CI runners.

Motivation

The test still times out occasionally (example in main) after 3 minutes on macOS Gitlab runners when running with -p 12 -parallel 12, despite previous tentative fix (#43207) which added GOPRIVATE=* and GOPROXY=off.

analysistest.Run internally runs go build commands to verify the Go toolchain works. When multiple tests run concurrently with the same shared GOCACHE, they can deadlock in Go's process management layer (see golang/go#59657).

Changes

Added per-test isolated GOCACHE directory using t.TempDir(), following the same approach as PR #39687 which fixed a similar timeout issue in comp/core/secrets/impl/fetch_secret_test.go.

Describe how you validated your changes

Verified locally with go test -v -race -count=20 -parallel 12 -timeout 600s.

Additional Notes

Prior art include:

💡 -mod=vendor could be also factored out through a future PR should the problem manifest itself again after the present change is merged.

@rdesgroppes rdesgroppes requested a review from a team as a code owner December 5, 2025 13:26
@rdesgroppes rdesgroppes requested a review from hush-hush December 5, 2025 13:26
@rdesgroppes rdesgroppes added qa/no-code-change No code change in Agent code requiring validation backport labels Dec 5, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 5, 2025
…`pkgconfigusage` (#43773)

### What does this PR do?
Add `GOCACHE` isolation to `TestAll` in `pkg/linters/components/pkgconfigusage` to reduce test timeouts on macOS CI runners.

### Motivation
The test still times out occasionally ([example in `main`](http://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1267508733/viewer#L2040)) after 3 minutes on macOS Gitlab runners when running with `-p 12 -parallel 12`, despite previous tentative fix (#43207) which added `GOPRIVATE=*` and `GOPROXY=off`.

`analysistest.Run` internally runs `go build` commands to verify the Go toolchain works.
When multiple tests run concurrently with the same shared `GOCACHE`, they can deadlock in Go's process management layer (see golang/go#59657).

### Changes
Added per-test isolated `GOCACHE` directory using `t.TempDir()`, following the same approach as PR #39687 which fixed a similar timeout issue in `comp/core/secrets/impl/fetch_secret_test.go`.

### Describe how you validated your changes
Verified locally with `go test -v -race -count=20 -parallel 12 -timeout 600s`.

### Additional Notes
Prior art include:
- #39518
- #39687
- #43207
- #43627

💡 `-mod=vendor` could be also factored out through a future PR should the problem manifest itself again after the present change is merged.
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/partial-backport-of-43773-to-7.74.x branch from b44d2d6 to d34a25c Compare December 5, 2025 13:27
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 5, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 45bf973

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0.36}$$ $${705.01}$$ < $${717.44}$$ $${+0.05}$$ $${172.89}$$ < $${177.37}$$
agent_deb_amd64_fips $${-0.35}$$ $${699.85}$$ < $${711.66}$$ $${-0.04}$$ $${171.74}$$ < $${174.84}$$
agent_heroku_amd64 $${-0.36}$$ $${326.37}$$ < $${337.57}$$ $${+0.1}$$ $${87.34}$$ < $${90.78}$$
agent_msi $${+1.53}$$ $${982.66}$$ < $${1015.38}$$ $${+0.31}$$ $${142.36}$$ < $${149.42}$$
agent_rpm_amd64 $${-0.36}$$ $${704.99}$$ < $${717.41}$$ $${-0.01}$$ $${175.91}$$ < $${178.01}$$
agent_rpm_amd64_fips $${-0.35}$$ $${699.84}$$ < $${711.64}$$ $${-0.08}$$ $${173.93}$$ < $${177.26}$$
agent_rpm_arm64 $${-0.09}$$ $${690.63}$$ < $${702.19}$$ $${-0.13}$$ $${159.67}$$ < $${163.22}$$
agent_rpm_arm64_fips $${-0.09}$$ $${686.5}$$ < $${697.6}$$ $${-0.09}$$ $${159.05}$$ < $${162.68}$$
agent_suse_amd64 $${-0.36}$$ $${704.99}$$ < $${717.41}$$ $${-0.01}$$ $${175.91}$$ < $${178.01}$$
agent_suse_amd64_fips $${-0.35}$$ $${699.84}$$ < $${711.64}$$ $${-0.08}$$ $${173.93}$$ < $${177.26}$$
agent_suse_arm64 $${-0.09}$$ $${690.63}$$ < $${702.19}$$ $${-0.13}$$ $${159.67}$$ < $${163.22}$$
agent_suse_arm64_fips $${-0.09}$$ $${686.5}$$ < $${697.6}$$ $${-0.09}$$ $${159.05}$$ < $${162.68}$$
docker_agent_amd64 $${-0.36}$$ $${767.35}$$ < $${769.92}$$ $${-0.14}$$ $${260.57}$$ < $${261.52}$$
docker_agent_arm64 $${-0.09}$$ $${777.31}$$ < $${779.46}$$ $${-0.15}$$ $${250.75}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${-0.36}$$ $${958.23}$$ < $${960.8}$$ $${-0.13}$$ $${329.22}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${-0.09}$$ $${956.91}$$ < $${958.93}$$ $${-0.14}$$ $${315.38}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${+0.5}$$ $${178.82}$$ < $${207.49}$$ $${+0.14}$$ $${63.14}$$ < $${70.2}$$
docker_cluster_agent_arm64 $${+0.5}$$ $${196.33}$$ < $${223.38}$$ $${+0.14}$$ $${59.88}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 $${-0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${-0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0}$$ $${38.57}$$ < $${39.3}$$ $${+0}$$ $${14.9}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${+0}$$ $${37.24}$$ < $${37.94}$$ $${+0}$$ $${14.36}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${+0}$$ $${29.79}$$ < $${30.53}$$ $${+0}$$ $${7.86}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${+0}$$ $${28.3}$$ < $${29.11}$$ $${-0}$$ $${6.8}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${+0}$$ $${29.79}$$ < $${30.53}$$ $${+0}$$ $${7.87}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${+0}$$ $${29.79}$$ < $${30.53}$$ $${+0}$$ $${7.87}$$ < $${8.76}$$
iot_agent_deb_amd64 $${+0}$$ $${42.54}$$ < $${43.19}$$ $${+0}$$ $${11.11}$$ < $${11.98}$$
iot_agent_deb_arm64 $${+0}$$ $${40.28}$$ < $${40.92}$$ $${+0}$$ $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf $${+0}$$ $${40.19}$$ < $${40.86}$$ $${+0}$$ $${9.68}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${+0}$$ $${42.54}$$ < $${43.19}$$ $${-0}$$ $${11.12}$$ < $${12.0}$$
iot_agent_suse_amd64 $${+0}$$ $${42.54}$$ < $${43.19}$$ $${-0}$$ $${11.12}$$ < $${12.0}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 5, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a6e4d81f-f669-4ad8-ba90-b118b8a7f771

Baseline: 15fd09a
Comparison: d34a25c
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.33 [-1.64, +4.30] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.33 [-1.64, +4.30] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.32 [+0.09, +0.56] 1 Logs
ddot_logs memory utilization +0.08 [+0.02, +0.15] 1 Logs
otlp_ingest_logs memory utilization +0.04 [-0.06, +0.14] 1 Logs
quality_gate_idle_all_features memory utilization +0.04 [-0.01, +0.09] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.03 [-0.02, +0.09] 1 Logs
quality_gate_idle memory utilization +0.03 [-0.02, +0.09] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.03 [-0.20, +0.25] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.01 [-0.36, +0.38] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.12, +0.14] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.08, +0.07] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.40, +0.37] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.06, +0.03] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.45, +0.38] 1 Logs
file_tree memory utilization -0.04 [-0.09, +0.00] 1 Logs
ddot_metrics_sum_delta memory utilization -0.23 [-0.44, -0.03] 1 Logs
docker_containers_memory memory utilization -0.25 [-0.34, -0.16] 1 Logs
otlp_ingest_metrics memory utilization -0.31 [-0.46, -0.17] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.40 [-0.56, -0.25] 1 Logs
quality_gate_metrics_logs memory utilization -0.71 [-0.92, -0.50] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.97 [-2.45, +0.51] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -1.70 [-1.79, -1.61] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@spencergilbert spencergilbert self-assigned this Dec 5, 2025
@spencergilbert
Copy link
Contributor

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 5, 2025

View all feedbacks in Devflow UI.

2025-12-05 14:40:27 UTC ℹ️ Start processing command /merge


2025-12-05 14:40:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in 7.74.x is approximately 32m (p90).


2025-12-05 14:56:29 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit b030948 into 7.74.x Dec 5, 2025
276 checks passed
@dd-mergequeue dd-mergequeue bot deleted the regis.desgroppes/partial-backport-of-43773-to-7.74.x branch December 5, 2025 14:56
@github-actions github-actions bot added this to the 7.74.0 milestone Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants