WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@lebauce
Copy link
Contributor

@lebauce lebauce commented Nov 20, 2025

What does this PR do?

Kata containers makes use of microVM to run pods. In these environments, network may not be available at all. vsock allows communication between the host and the guest through the hypervisor, without using TCP sockets.

DataDog/datadog-agent#39478 added support for vsock sockets in the agent.

This PR modifies the Helm Charts by:

  • setting the right configs (DD_VSOCK_ADDR, ...) to enable the feature
  • set the /etc/datadog-agent/auth as a hostpath so that it can be shared with the microVM through virtiofs

Motivation

Some environments do not allow workload to have network interfaces. Using vsock sockets
allow these workloads to communicate with the agent.

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: v7.74.0
  • Cluster Agent: v7.74.0

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@lebauce lebauce requested review from a team as code owners November 20, 2025 14:37
@lebauce lebauce added enhancement New feature or request qa/skip-qa labels Nov 20, 2025
@lebauce lebauce added this to the v1.22.0 milestone Nov 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 18.75000% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.47%. Comparing base (71bf50d) to head (374e702).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/datadogagent/common/volumes.go 0.00% 9 Missing ⚠️
...controller/datadogagent/component/agent/default.go 25.00% 8 Missing and 1 partial ⚠️
...nal/controller/datadogagent/feature/cws/feature.go 30.76% 7 Missing and 2 partials ⚠️
internal/controller/datadogagent/global/global.go 0.00% 8 Missing and 1 partial ⚠️
...datadogagentinternal/controller_reconcile_agent.go 0.00% 2 Missing ⚠️
...troller/datadogagent/controller_reconcile_agent.go 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (18.75%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2336      +/-   ##
==========================================
+ Coverage   36.92%   37.47%   +0.54%     
==========================================
  Files         273      281       +8     
  Lines       22926    25081    +2155     
==========================================
+ Hits         8466     9398     +932     
- Misses      13821    14975    +1154     
- Partials      639      708      +69     
Flag Coverage Δ
unittests 37.47% <18.75%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ler/datadogagent/component/clusteragent/default.go 98.67% <100.00%> (ø)
internal/controller/datadogagent/global/agent.go 83.72% <ø> (ø)
...troller/datadogagent/controller_reconcile_agent.go 62.41% <50.00%> (ø)
...datadogagentinternal/controller_reconcile_agent.go 4.50% <0.00%> (ø)
internal/controller/datadogagent/common/volumes.go 0.00% <0.00%> (ø)
...controller/datadogagent/component/agent/default.go 11.36% <25.00%> (+4.12%) ⬆️
...nal/controller/datadogagent/feature/cws/feature.go 77.86% <30.76%> (-0.56%) ⬇️
internal/controller/datadogagent/global/global.go 46.73% <0.00%> (-2.22%) ⬇️

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71bf50d...374e702. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lebauce lebauce force-pushed the lebauce/vsock-support branch from 0ce350e to d7d0987 Compare December 3, 2025 15:26
@lebauce lebauce force-pushed the lebauce/vsock-support branch from d7d0987 to 1163533 Compare December 3, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants