Enable Spotbugs and Spotless for modules that require JDK21+. (#10092)

AlexeyKuznetsov-DD · web-flow · commit f38cc2ee7aa2 · 2025-12-10T20:13:43.000-05:00
diff --git a/dd-smoke-tests/concurrent/java-21/build.gradle b/dd-smoke-tests/concurrent/java-21/build.gradle
@@ -32,10 +32,6 @@ tasks.named("forbiddenApisMain") {
   failOnMissingClasses = false
 }
 
-['spotlessApply', 'spotlessCheck', 'spotlessJava', 'spotbugsMain'].each {
-  tasks.named(it) { enabled = false }
-}
-
 application {
   mainClass = 'datadog.smoketest.concurrent.ConcurrentApp'
 }
diff --git a/dd-smoke-tests/concurrent/java-21/src/main/java/datadog/smoketest/concurrent/VirtualThreadStartCalculator.java b/dd-smoke-tests/concurrent/java-21/src/main/java/datadog/smoketest/concurrent/VirtualThreadStartCalculator.java
@@ -14,6 +14,7 @@ public long computeFibonacci(int n) throws ExecutionException, InterruptedExcept
 
   @Override
   public void close() {
+    // No-op.
   }
 
   public static class FibonacciExecuteTask implements Runnable {
diff --git a/dd-smoke-tests/concurrent/java-25/build.gradle b/dd-smoke-tests/concurrent/java-25/build.gradle
@@ -45,10 +45,6 @@ tasks.named("forbiddenApisMain") {
   failOnMissingClasses = false
 }
 
-['spotlessApply', 'spotlessCheck', 'spotlessJava', 'spotbugsMain'].each {
-  tasks.named(it) { enabled = false }
-}
-
 application {
   mainClass = 'datadog.smoketest.concurrent.ConcurrentApp'
 }
diff --git a/dd-smoke-tests/concurrent/java-25/src/main/java/datadog/smoketest/concurrent/NestedTasks.java b/dd-smoke-tests/concurrent/java-25/src/main/java/datadog/smoketest/concurrent/NestedTasks.java
@@ -33,6 +33,7 @@ void task2() {
   void subTask1() {
     // Some basic computations here
   }
+
   @WithSpan("great-child1-2")
   void subTask2() {
     // Some basic computations here

Original file line number	Diff line number	Diff line change
`@@ -32,10 +32,6 @@ tasks.named("forbiddenApisMain") {`
`32`	`32`	`failOnMissingClasses = false`
`33`	`33`	`}`
`34`	`34`
`35`		`-['spotlessApply', 'spotlessCheck', 'spotlessJava', 'spotbugsMain'].each {`
`36`		`- tasks.named(it) { enabled = false }`
`37`		`-}`
`38`		`-`
`39`	`35`	`application {`
`40`	`36`	`mainClass = 'datadog.smoketest.concurrent.ConcurrentApp'`
`41`	`37`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ public long computeFibonacci(int n) throws ExecutionException, InterruptedExcept`
`14`	`14`
`15`	`15`	`@Override`
`16`	`16`	`public void close() {`
	`17`	`+ // No-op.`
`17`	`18`	`}`
`18`	`19`
`19`	`20`	`public static class FibonacciExecuteTask implements Runnable {`
Original file line number	Diff line number	Diff line change
`@@ -45,10 +45,6 @@ tasks.named("forbiddenApisMain") {`
`45`	`45`	`failOnMissingClasses = false`
`46`	`46`	`}`
`47`	`47`
`48`		`-['spotlessApply', 'spotlessCheck', 'spotlessJava', 'spotbugsMain'].each {`
`49`		`- tasks.named(it) { enabled = false }`
`50`		`-}`
`51`		`-`
`52`	`48`	`application {`
`53`	`49`	`mainClass = 'datadog.smoketest.concurrent.ConcurrentApp'`
`54`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ void task2() {`
`33`	`33`	`void subTask1() {`
`34`	`34`	`// Some basic computations here`
`35`	`35`	`}`
	`36`	`+`
`36`	`37`	`@WithSpan("great-child1-2")`
`37`	`38`	`void subTask2() {`
`38`	`39`	`// Some basic computations here`