Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the automatic WaterDrop integration activation (via the Karafka integration).
For context, by the time that
Karafka::App#initialized!is called,Karafka.producerwas already initialized.Not only that, there's really nowhere we can hook in the Karafka initialization where we can be sure that
Karafka.producerwasn't yet initiaized - that's because the Karafka initialization is NOT necessarily tied to the WaterDrop initialization. For instance, the following is a possible scenario:So instead of trying to hook somewhere before
Karafka.produceris initialized, let's simply listen to a Karafka after-initialization event and append our middleware to the producer when that event is triggered.Motivation:
We've noticed that
WaterDropdistributed tracing was not working after configuring only the Karafka integration.Change log entry
Additional Notes:
How to test the change?