WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@wantsui
Copy link
Contributor

@wantsui wantsui commented Nov 24, 2025

Motivation

Changes

Brings the following postgres metrics building off https://github.com/DataDog/system-tests/pull/5752/files:

  1. rollbacks
  2. vacuums
  3. blocks_read
  4. index scans
  5. commented out metrics

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@wantsui wantsui requested a review from quinna-h November 24, 2025 21:53
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

CODEOWNERS have been resolved as:

utils/otel_validators/validator_metrics.py                              @DataDog/system-tests-core
tests/otel_postgres_metrics_e2e/test_postgres_metrics.py                @DataDog/system-tests-core
utils/_context/containers.py                                            @DataDog/system-tests-core
utils/build/docker/otelcol-config-with-postgres.yaml                    @DataDog/system-tests-core
utils/otel_validators/__init__.py                                       @DataDog/system-tests-core

Base automatically changed from refactor-postgres-metrics-test-module to main November 25, 2025 22:26
Copy link
Contributor

@quinna-h quinna-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; the CI failure is expected because this otel collector image version is not compatible with some of the metrics. This test failure is accurate and should be captured by our testing pipeline.

This PR should fix the issues seen: update otel collector image version

@quinna-h
Copy link
Contributor

quinna-h commented Dec 8, 2025

Update: looks like updating the collector image version has fixed the previously failing jobs in CI

@quinna-h quinna-h marked this pull request as ready for review December 8, 2025 15:28
@quinna-h quinna-h requested a review from a team as a code owner December 8, 2025 15:28
@quinna-h quinna-h merged commit 418030a into main Dec 8, 2025
3168 of 3173 checks passed
@quinna-h quinna-h deleted the add-missing-postgres-metrics branch December 8, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants