WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@abradley60
Copy link
Collaborator

  • Adding the Copernicus Australasia Datahub (AUS_COP_HUB) as a data source for downloading orbit files
    • A query is sent to the hub using pygssearch for orbit files within +-2 days that the scene was acquired.
    • The results are filtered for the file that acquisition time of the scene lies within,
  • Tests are updated to consider AUS_COP_HUB for downloading orbit files
  • Updating docs
  • Minor change to CLI : moving where the burst file gets created
  • Changes to pyproject.toml and pixi file to reflect test updates.

@abradley60
Copy link
Collaborator Author

@arcisad I have added you to this PR for visibility. Feel free to look it over if you have some time - you will get more familiar with the workings over time.

Copy link
Collaborator

@geoscience-aman geoscience-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! Awesome to use Aus CopHub.

My suggestions are basically typo fixes.

f"{len(orbit_paths)} orbit paths found for scene. Expecting 1."
if len(orbit_paths) == 0:
raise OrbitNotFoundError(f"Orbit file could not be found for scene.")
elif len() > 1:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

len(orbit_paths)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

from datetime import datetime, timedelta
import subprocess
import re

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to import os?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see os imported on the first line?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I can too in the full view. Sorry ignore that one!

orbit_data_source_preferences: (
ValidOrbitDataSources | list[ValidOrbitDataSources]
) = VALID_ORBIT_DATA_SOURCES,
) -> list[Path]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Path without the list since we return orbit_paths[0]?

f"--token_url {token_url} "
f"--client_id {aus_cop_hub_client_id} "
f"--client_secret {aus_cop_hub_client_secret} "
f"--name {orbit_file_name}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space at the end of the line here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks

@geoscience-aman geoscience-aman self-requested a review December 3, 2025 01:27
@abradley60 abradley60 merged commit e830cc9 into main Dec 4, 2025
2 of 5 checks passed
@abradley60 abradley60 deleted the update/aus_cop_hub_orbits branch December 4, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants