-
Notifications
You must be signed in to change notification settings - Fork 3
Update/aus cop hub orbits #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
abradley60
commented
Dec 2, 2025
- Adding the Copernicus Australasia Datahub (AUS_COP_HUB) as a data source for downloading orbit files
- A query is sent to the hub using pygssearch for orbit files within +-2 days that the scene was acquired.
- The results are filtered for the file that acquisition time of the scene lies within,
- Tests are updated to consider AUS_COP_HUB for downloading orbit files
- Updating docs
- Minor change to CLI : moving where the burst file gets created
- Changes to pyproject.toml and pixi file to reflect test updates.
|
@arcisad I have added you to this PR for visibility. Feel free to look it over if you have some time - you will get more familiar with the workings over time. |
geoscience-aman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex! Awesome to use Aus CopHub.
My suggestions are basically typo fixes.
| f"{len(orbit_paths)} orbit paths found for scene. Expecting 1." | ||
| if len(orbit_paths) == 0: | ||
| raise OrbitNotFoundError(f"Orbit file could not be found for scene.") | ||
| elif len() > 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
len(orbit_paths)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!
| from datetime import datetime, timedelta | ||
| import subprocess | ||
| import re | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to import os?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see os imported on the first line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I can too in the full view. Sorry ignore that one!
| orbit_data_source_preferences: ( | ||
| ValidOrbitDataSources | list[ValidOrbitDataSources] | ||
| ) = VALID_ORBIT_DATA_SOURCES, | ||
| ) -> list[Path]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be Path without the list since we return orbit_paths[0]?
| f"--token_url {token_url} " | ||
| f"--client_id {aus_cop_hub_client_id} " | ||
| f"--client_secret {aus_cop_hub_client_secret} " | ||
| f"--name {orbit_file_name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space at the end of the line here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch thanks