Improve definition references #3451
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgerhant
commented
Dec 7, 2025
adamgerhant
force-pushed
the
improve-definitions
branch
from
f443176 to
0958e50
Compare
adamgerhant
force-pushed
the
improve-definitions
branch
from
e5d9913 to
3ac9dfe
Compare
adamgerhant
commented
Dec 9, 2025
| RegistryWidgetOverride::Custom(str) => InputMetadata::with_name_description_override(f.name, f.description, WidgetOverride::Custom(str.to_string())), | ||
| }) | ||
| .collect(), | ||
| output_names: vec![output_type.to_string()], |
Collaborator
Author
There was a problem hiding this comment.
Removed since the output name of a protonode should not be a single random output type, as this can change and should be based on the current graph state.
adamgerhant
commented
Dec 9, 2025
| document.network_interface.set_input(&InputConnector::node(*node_id, 2), old_inputs[3].clone(), network_path); | ||
| } | ||
|
|
||
| if reference == "Flatten Vector Elements" { |
Collaborator
Author
There was a problem hiding this comment.
not possible to include this migration since it relies on changing reference to not run again, which is no longer possible.
adamgerhant
commented
Dec 9, 2025
adamgerhant
force-pushed
the
improve-definitions
branch
from
a17cfc5 to
869967c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the definition reference system by referencing nodes with
DefinitionIdentifierinstead of strings. This means protonodes use their identifier to reference their definition, instead of an arbitrary string.Sets the foundation for an improved migration system and linking nodes to their definition when serializing.
For example:
instead of
you would do
Another example
to