WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Dec 8, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

Follow up to #21190. We enabled migration over 4 years ago since #12248, which was part of brew 3.3.0. So at least 2 major brew releases have passed and all active Linuxbrew users would have been migrated already.

There are only 25 formulae left so anyone who hasn't migrated can just reinstall formulae if impacted.

Follow up to #21190. We enabled migration over 4 years ago
since #12248, which was part of brew 3.3.0. So at least 2
major brew releases have passed and all active Linuxbrew users would
have been migrated already.

There are only 25 formulae left so anyone who hasn't migrated can just
reinstall formulae if impacted.
Copilot AI review requested due to automatic review settings December 8, 2025 17:39
@cho-m
Copy link
Member Author

cho-m commented Dec 8, 2025

For now, just removed the formulae migration logic.

There is also the git repo migration (i.e. stuff under HOMEBREW_LINUXBREW_CORE_MIGRATION environment variable).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy linuxbrew-core formulae migration code that has been in place for over 4 years (since Homebrew 3.3.0). The migration logic is no longer needed as all active Linuxbrew users would have migrated already, and the remaining 25 formulae can be manually reinstalled if necessary.

  • Deletes the migration constants file containing the list of 25 formulae with special version handling
  • Removes shell script logic that triggered and tracked migration status
  • Removes Ruby code that performed the actual formula migration by modifying version schemes

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Library/Homebrew/linuxbrew-core-migration.rb Complete deletion of migration constants (LINUXBREW_CORE_MIGRATION_OLD_PKG_VERSIONS and LINUXBREW_CORE_MIGRATION_LIST)
Library/Homebrew/cmd/update.sh Removes git config logic for tracking migration state and condition checks for HOMEBREW_MIGRATE_LINUXBREW_FORMULAE
Library/Homebrew/cmd/update-report.rb Removes the migration execution logic that modified formula tabs and Settings, plus removes HOMEBREW_MIGRATE_LINUXBREW_FORMULAE from conditional

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid enabled auto-merge December 8, 2025 17:50
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 8, 2025
@cho-m cho-m added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit afb6622 Dec 8, 2025
43 checks passed
@cho-m cho-m deleted the remove-migrating-linuxbrew-formulae branch December 8, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants