Merge pull request #1601 from Kotlin/optin-experimental-instant

Optin experimental Instant in codegen if this type is used

Author: AndreiKingsley

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/codeGen/ReplCodeGeneratorImpl.kt

@@ -15,14 +15,18 @@ import org.jetbrains.kotlinx.dataframe.codeGen.Marker
 import org.jetbrains.kotlinx.dataframe.codeGen.MarkerVisibility
 import org.jetbrains.kotlinx.dataframe.codeGen.MarkersExtractor
 import org.jetbrains.kotlinx.dataframe.codeGen.TypeCastGenerator
+import org.jetbrains.kotlinx.dataframe.schema.ColumnSchema
 import org.jetbrains.kotlinx.dataframe.schema.DataFrameSchema
 import kotlin.reflect.KClass
 import kotlin.reflect.KProperty
 import kotlin.reflect.KType
 import kotlin.reflect.KVisibility
 import kotlin.reflect.full.findAnnotation
+import kotlin.reflect.full.isSubtypeOf
 import kotlin.reflect.full.superclasses
 import kotlin.reflect.jvm.jvmErasure
+import kotlin.reflect.typeOf
+import kotlin.time.Instant
 
 internal class ReplCodeGeneratorImpl : ReplCodeGenerator {
 
@@ -116,9 +120,24 @@ internal class ReplCodeGeneratorImpl : ReplCodeGenerator {
         result.newMarkers.forEach {
             generatedMarkers[it.name] = it
         }
-        return result.code
+        return if (schema.hasExperimentalInstant()) {
+            result.code.copy(
+                declarations = "@file:OptIn(kotlin.time.ExperimentalTime::class)\n" + result.code.declarations,
+            )
+        } else {
+            result.code
+        }
     }
 
+    private fun DataFrameSchema.hasExperimentalInstant(): Boolean =
+        columns.values.any { column ->
+            when (column) {
+                is ColumnSchema.Frame -> column.schema.hasExperimentalInstant()
+                is ColumnSchema.Group -> column.schema.hasExperimentalInstant()
+                is ColumnSchema.Value -> column.type.isSubtypeOf(typeOf<Instant?>())
+            }
+        }
+
     override fun process(markerClass: KClass<*>): Code {
         val newMarkers = mutableListOf<Marker>()
 

dataframe-jupyter/src/test/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/JupyterCodegenTests.kt

@@ -33,6 +33,24 @@ class JupyterCodegenTests : JupyterReplTestCase() {
         res2["value"].type shouldBe typeOf<List<Any?>>()
     }
 
+    @Test
+    fun `opt in experimental Instant`() {
+        @Language("kts")
+        val res1 = execRaw(
+            """
+            @file:OptIn(ExperimentalTime::class)
+
+            import kotlin.time.ExperimentalTime
+            
+            val values: kotlin.time.Instant = kotlin.time.Clock.System.now()
+            val df = dataFrameOf("a" to columnOf(values))
+            df
+            """.trimIndent(),
+        )
+
+        res1.shouldBeInstanceOf<AnyFrame>()
+    }
+
     @Test
     fun `Don't inherit from data class`() {
         @Language("kts")