WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Data converter doesn't work with DataManipulators which aren't VariantData objects #21

@caseif

Description

@caseif

Pore's data converter does not function properly if given a DataManipulator which is not a VariantData object. Subsequently, it needs to be modified to support all manipulators, and not just ones with a single value.

Case in point: Two of the (presently disabled) block data converter tests for minecraft:log and minecraft:log2 block types fail because AxisData no longer extends VariantData (previously SingleValueData in Data 1.0), so the converter doesn't know how to handle it and simply doesn't, providing an incorrect deabstracted value.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions