This repository was archived by the owner on Jan 1, 2024. It is now read-only.
This repository was archived by the owner on Jan 1, 2024. It is now read-only.
Lightning Gallery - engineering review #4
Description
Thanks for submitting your component to Lightning Gallary.
Looks good. Here is some feedback regarding LAI-Redis-Component in order to get accepted in the Lightning Gallery.
1- Could you rename the environment variable REDIS_PASSWORD maybe to LIGHTNING_COMPONENT_REDIS_PASSWORD
2- Could you specify which Redis version this component runs and how to change the version if possible?
3- When I run the app on the cloud it shows some confusing messages:
[root.lightning_redis] 2022-07-27T10:53:50.791Z 212:M 27 Jul 2022 10:53:50.790 * Ready to accept connections
[root.lightning_redis] 2022-07-27T10:53:51.797Z INFO: redis password set
[root.lightning_redis] 2022-07-27T10:53:51.818Z 212:M 27 Jul 2022 10:53:51.818 # Possible SECURITY ATTACK detected. It looks like somebody is sending POST or Host: commands to Redis. This is likely due to an attacker attempting to use Cross Protocol Scripting to compromise your Redis instance. Connection aborted.
4- Nice to have: Steps to run the component locally.
If you have any questions, please reach out! we will be happy to assist you to land your component to the Lightning gallery.
FYI: @zippeurfou @hhsecond