WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com

Update apache-spark-sql-connector.md #127981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

aukponmwan wants to merge 1 commit into MicrosoftDocs:main from aukponmwan:patch-3

Contributor

aukponmwan commented Dec 4, 2025

Replacing the SQL Server Connector for Apache Spark documentation.


          Update apache-spark-sql-connector.md

0508e1f

prmerger-automator bot added the do-not-merge label

prmerger-automator bot assigned eric-urban

prmerger-automator bot requested review from eric-urban and ms-arali

December 4, 2025 17:52

Contributor

prmerger-automator bot commented Dec 4, 2025

@aukponmwan : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

prmerger-automator bot added azure-synapse-analytics/svc Change sent to author labels

Contributor

learn-build-service-prod bot commented Dec 4, 2025

Learn Build status updates of commit 0508e1f:

💡 Validation status: suggestions

File	Status	Preview URL	Details
articles/synapse-analytics/spark/data-sources/apache-spark-sql-connector.md	💡Suggestion		Details

articles/synapse-analytics/spark/data-sources/apache-spark-sql-connector.md

Line 188, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/fabric/database/sql/overview' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Contributor

prmerger-automator bot commented Dec 4, 2025

PRMerger Results

Issue	Description
File Change Percent	This PR contains file(s) with more than 30% file change.

prmerger-automator bot added the needs-human-review label

v-dirichards requested a review from Copilot

December 4, 2025 22:37

Contributor

v-dirichards commented Dec 4, 2025

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

prmerger-automator bot added the aq-pr-triaged label

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

This PR replaces the Apache Spark SQL Server connector documentation with updated guidance for the new Spark connector for SQL databases (Preview). The update reflects a modernized connector preinstalled in Synapse Spark 3.5 runtime with enhanced capabilities.

Key changes:

Introduces the preview Spark connector for SQL databases with support for multiple SQL database types (Azure SQL, SQL Managed Instance, SQL Server on Azure VM, and Fabric SQL databases)
Updates authentication guidance to emphasize integrated Microsoft Entra ID authentication as the default method
Replaces legacy code examples with modern PySpark and Scala examples using the .mssql() method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

articles/synapse-analytics/spark/data-sources/apache-spark-sql-connector.md

    
                      .option("hostNameInCertificate", "*.database.windows.net") \

                      .load()

              ```python

              import com.microsoft.sqlserver.jdbc.spark

Copilot AI Dec 4, 2025

This import statement uses Java/Scala syntax in a PySpark code block. Python doesn't use this import syntax. Remove this line or use the correct Python import if one is required for the connector.

Suggested change

import com.microsoft.sqlserver.jdbc.spark

Copilot uses AI. Check for mistakes.

articles/synapse-analytics/spark/data-sources/apache-spark-sql-connector.md

    
                      .option("encrypt", "true") \

                      .option("hostNameInCertificate", "*.database.windows.net") \

                      .load()

              import com.microsoft.sqlserver.jdbc.spark

Copilot AI Dec 4, 2025

This import statement uses Java/Scala syntax in a PySpark code block. Python doesn't use this import syntax. Remove this line or use the correct Python import if one is required for the connector.

Suggested change

import com.microsoft.sqlserver.jdbc.spark

Copilot uses AI. Check for mistakes.

articles/synapse-analytics/spark/data-sources/apache-spark-sql-connector.md

    
              # [User/Password](#tab/userandpassword)

              ```python

              import com.microsoft.sqlserver.jdbc.spark

Copilot AI Dec 4, 2025

This import statement uses Java/Scala syntax in a PySpark code block. Python doesn't use this import syntax. Remove this line or use the correct Python import if one is required for the connector.

Suggested change

import com.microsoft.sqlserver.jdbc.spark

Copilot uses AI. Check for mistakes.

articles/synapse-analytics/spark/data-sources/apache-spark-sql-connector.md

    
              import org.apache.spark.sql.types._

              val url = "jdbc:sqlserver://<server>:<port>;database=<database>;"

              val row_data = Seq(

                Row("Alice", 2),

Copilot AI Dec 4, 2025

Age value for 'Alice' is inconsistent with the PySpark example (line 87) where it's 1. This inconsistency could confuse readers trying to understand the examples.

Suggested change

      
              Row("Alice", 2),
          
              Row("Alice", 1),

Copilot uses AI. Check for mistakes.

articles/synapse-analytics/spark/data-sources/apache-spark-sql-connector.md

Comment on lines +148 to +149

    
              df.write.mode("overwrite").option("url", url).option("accesstoken", token).mssql("dbo.publicExample")

              spark.read.option("accesstoken", token).mssql("dbo.publicExample").show()

Copilot AI Dec 4, 2025

[nitpick] The option name 'accesstoken' is inconsistent with typical casing conventions. Consider using 'accessToken' (camelCase) to match the option naming pattern shown in the legacy code examples and common convention.

Suggested change

      
            df.write.mode("overwrite").option("url", url).option("accesstoken", token).mssql("dbo.publicExample")
          
            spark.read.option("accesstoken", token).mssql("dbo.publicExample").show()
          
            df.write.mode("overwrite").option("url", url).option("accessToken", token).mssql("dbo.publicExample")
          
            spark.read.option("accessToken", token).mssql("dbo.publicExample").show()

Copilot uses AI. Check for mistakes.

Contributor

ms-arali commented Dec 5, 2025

#sign-off

Contributor

prmerger-automator bot commented Dec 5, 2025

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @eric-urban

ms-arali approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aq-pr-triaged azure-synapse-analytics/svc Change sent to author do-not-merge needs-human-review