WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

SortedRecords::find_apex_rtype() could be more efficient and better named. #519

@ximon18

Description

@ximon18

Currently SortedRecords::find_apex_rtype() searches for any RRSET of the right type and owner.

There are two minor issues with this:

  1. The owner to search for can be any owner, not just the apex, which makes the fn name a bit misleading.
  2. If the RRSET type wanted doesn't exist the search will iterate over every record in the collection even though the matching owner may already have been found and checked (as the records are sorted).

For small zones this won't matter but it might for larger zones, especially if searching multiple times for different record types, e.g. DNSKEY, CDNSKEY and CDS.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions