-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix PNPM Migration, Docker Build Errors #4901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
rawadhossain
wants to merge
9
commits into
PalisadoesFoundation:develop
from
rawadhossain:fix/docker-build-error
Closed
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7b65906
fix: docker build error
rawadhossain 221ec7d
fix: coderabbit suggestions fix
rawadhossain 8c99572
fix: spec file tests fix
rawadhossain d7c961a
fix: e2e coverage report fix
rawadhossain 5c73735
fix: script fix
rawadhossain cf13230
fix: generate lcov fix
rawadhossain 4cdbd32
fix: generate lcov fix
rawadhossain 07ac611
fix: coverage report fix
rawadhossain 38755d9
fix: coverage report summary fix
rawadhossain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,9 +11,13 @@ ARG PORT=4321 | |
| ENV PORT=${PORT} | ||
|
|
||
| WORKDIR /usr/src/app | ||
| RUN corepack enable && corepack prepare [email protected] --activate | ||
|
|
||
| COPY package.json pnpm-lock.yaml ./ | ||
| RUN pnpm install --frozen-lockfile | ||
|
|
||
| RUN corepack enable \ | ||
| && corepack prepare [email protected] --activate \ | ||
| && pnpm install --frozen-lockfile --reporter=append-only | ||
|
|
||
| COPY . . | ||
| RUN pnpm run build | ||
| ENV NODE_ENV=production | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,9 +5,14 @@ ENV PORT=${PORT} | |
|
|
||
| WORKDIR /usr/src/app | ||
|
|
||
| RUN corepack enable && corepack prepare [email protected] --activate | ||
| # Enable pnpm globally | ||
| RUN corepack enable | ||
|
|
||
| # Copy dependency manifests only | ||
| COPY package.json pnpm-lock.yaml ./ | ||
| RUN pnpm install --frozen-lockfile | ||
|
|
||
| RUN corepack prepare [email protected] --activate \ | ||
| && pnpm install --frozen-lockfile --reporter=append-only | ||
|
|
||
| COPY . . | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,9 +2,15 @@ | |
| FROM node:24-slim AS builder | ||
| WORKDIR /talawa-admin | ||
|
|
||
| RUN corepack enable && corepack prepare [email protected] --activate | ||
| # Enable pnpm globally | ||
| RUN corepack enable | ||
|
|
||
rawadhossain marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # Copy dependency manifests | ||
| COPY package.json pnpm-lock.yaml ./ | ||
| RUN pnpm install --frozen-lockfile | ||
|
|
||
| # Install dependencies | ||
| RUN corepack prepare [email protected] --activate \ | ||
| && pnpm install --frozen-lockfile --reporter=append-only | ||
|
|
||
| COPY . . | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -196,8 +196,43 @@ | |
| }, | ||
| "pnpm": { | ||
| "overrides": { | ||
| "@apollo/client": "3.14.0" | ||
| } | ||
| "@apollo/client": "3.14.0", | ||
| "@pdfme/common": "5.4.8", | ||
| "@pdfme/schemas": "5.4.8", | ||
| "@pdfme/generator": "5.4.8", | ||
| "rc-color-picker>react": "^19.1.0", | ||
| "rc-color-picker>react-dom": "^19.1.0", | ||
| "virtualizedtableforantd4>react": "^19.1.0", | ||
| "virtualizedtableforantd4>react-dom": "^19.1.0", | ||
| "@types/react": "^19.1.1", | ||
| "@types/react-dom": "^19.1.1", | ||
| "whatwg-url": "^14.0.0", | ||
| "core-js": "^3.40.0", | ||
| "sync-fetch": "npm:@ardatan/[email protected]", | ||
| "gulp-header": "^2.0.9", | ||
| "rimraf": "^6.1.2", | ||
| "glob": "^13.0.0", | ||
| "nyc": "17.1.0" | ||
| }, | ||
| "peerDependencyRules": { | ||
| "allowedVersions": { | ||
| "react": ">=16", | ||
| "react-dom": ">=16" | ||
| }, | ||
| "ignoreMissing": [ | ||
| "react", | ||
| "react-dom", | ||
| "@pdfme/common", | ||
| "@pdfme/schemas" | ||
| ] | ||
| }, | ||
| "onlyBuiltDependencies": [ | ||
| "esbuild", | ||
| "@parcel/watcher", | ||
| "core-js", | ||
| "cypress", | ||
| "sharp" | ||
| ] | ||
| }, | ||
| "engines": { | ||
| "node": ">=24.x" | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.