WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Naming conflicts which cause incorrect logic in BundlerInfo #336

@svew

Description

@svew

Minecraft version: 1.20.x
Mappings version: Commit hash c46f07b

In BundlerInfo, several of the below functions are nested within each other. addPacket is nested inside startPacketBundling , which is nested inside createForPacket . All three of these mappings introduce a packet argument, which causes checks like packet == packet to compare the same object to itself, which was not the original logic.

CLASS net/minecraft/network/protocol/BundlerInfo
	METHOD createForPacket (Lnet/minecraft/network/protocol/PacketType;Ljava/util/function/Function;Lnet/minecraft/network/protocol/BundleDelimiterPacket;)Lnet/minecraft/network/protocol/BundlerInfo;
		ARG 0 type
		ARG 1 bundler
		ARG 2 packet
	METHOD startPacketBundling (Lnet/minecraft/network/protocol/Packet;)Lnet/minecraft/network/protocol/BundlerInfo$Bundler;
		ARG 1 packet
	METHOD unbundlePacket (Lnet/minecraft/network/protocol/Packet;Ljava/util/function/Consumer;)V
		ARG 1 packet
		ARG 2 consumer
	CLASS Bundler
		METHOD addPacket (Lnet/minecraft/network/protocol/Packet;)Lnet/minecraft/network/protocol/Packet;
			ARG 1 packet

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugAn error, misspell, incorrect information, or other issuetriageNeeds attention for triaging and proper assignment of labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions