-
Notifications
You must be signed in to change notification settings - Fork 92
Open
Labels
bugAn error, misspell, incorrect information, or other issueAn error, misspell, incorrect information, or other issuetriageNeeds attention for triaging and proper assignment of labelsNeeds attention for triaging and proper assignment of labels
Description
Minecraft version: 1.20.x
Mappings version: Commit hash c46f07b
In BundlerInfo, several of the below functions are nested within each other. addPacket is nested inside startPacketBundling , which is nested inside createForPacket . All three of these mappings introduce a packet argument, which causes checks like packet == packet to compare the same object to itself, which was not the original logic.
CLASS net/minecraft/network/protocol/BundlerInfo
METHOD createForPacket (Lnet/minecraft/network/protocol/PacketType;Ljava/util/function/Function;Lnet/minecraft/network/protocol/BundleDelimiterPacket;)Lnet/minecraft/network/protocol/BundlerInfo;
ARG 0 type
ARG 1 bundler
ARG 2 packet
METHOD startPacketBundling (Lnet/minecraft/network/protocol/Packet;)Lnet/minecraft/network/protocol/BundlerInfo$Bundler;
ARG 1 packet
METHOD unbundlePacket (Lnet/minecraft/network/protocol/Packet;Ljava/util/function/Consumer;)V
ARG 1 packet
ARG 2 consumer
CLASS Bundler
METHOD addPacket (Lnet/minecraft/network/protocol/Packet;)Lnet/minecraft/network/protocol/Packet;
ARG 1 packet
Metadata
Metadata
Assignees
Labels
bugAn error, misspell, incorrect information, or other issueAn error, misspell, incorrect information, or other issuetriageNeeds attention for triaging and proper assignment of labelsNeeds attention for triaging and proper assignment of labels