Fixing ordering bug in "messages by teammates"

Messages were ordered by latest team message, not by latest overall
message.

Also renamed "teammates" to "team" to reflect the actual behavior, also
including the current user.

Author: dutow

app/controllers/topics_controller.rb

@@ -541,7 +541,7 @@ def apply_filters(base_query)
     when "team_messaged"
       if team_id
         member_alias_ids = Alias.joins(user: :team_members).where(team_members: { team_id: team_id }).select(:id)
-        base_query = base_query.joins(:messages).where(messages: { sender_id: member_alias_ids }).distinct
+        base_query = base_query.where(id: Message.where(sender_id: member_alias_ids).select(:topic_id))
       end
     end
     base_query

app/views/topics/_sidebar.html.slim

@@ -22,8 +22,8 @@
               li = link_to "#{team.name}: not yet read by team", topics_path(filter: "team_unread", team_id: team.id)
               li = link_to "#{team.name}: my teammates are reading", topics_path(filter: "team_reading_others", team_id: team.id)
               li = link_to "#{team.name}: my team is reading", topics_path(filter: "team_reading_any", team_id: team.id)
-              li = link_to "#{team.name}: started by teammate", topics_path(filter: "team_started", team_id: team.id)
-              li = link_to "#{team.name}: messages by teammates", topics_path(filter: "team_messaged", team_id: team.id)
+              li = link_to "#{team.name}: started by team", topics_path(filter: "team_started", team_id: team.id)
+              li = link_to "#{team.name}: messages by team", topics_path(filter: "team_messaged", team_id: team.id)
       - if user_signed_in? && @available_note_tags.present?
         .sidebar-section
           h3.sidebar-heading My tags