Unit Tests for stakeibc CLI (Stride-Labs#1220)

Co-authored-by: sampocs <[email protected]>

Author: assafmo

testutil/network/network.go

@@ -59,7 +59,7 @@ func DefaultConfig() network.Config {
 	// app doesn't have this module anymore, but we need them for test setup, which uses gentx
 	app.ModuleBasics[genutiltypes.ModuleName] = genutil.AppModuleBasic{}
 	encoding := app.MakeEncodingConfig()
-	chainId := "stride-" + cometbftrand.NewRand().Str(6)
+	chainId := fmt.Sprintf("stride-%d", cometbftrand.NewRand().Uint64())
 	return network.Config{
 		Codec:             encoding.Marshaler,
 		TxConfig:          encoding.TxConfig,

x/stakeibc/client/cli/cli_test.go

@@ -0,0 +1,26 @@
+package cli_test
+
+import (
+	"testing"
+
+	clitestutil "github.com/cosmos/cosmos-sdk/testutil/cli"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/spf13/cobra"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/cosmos/cosmos-sdk/client"
+
+	"github.com/Stride-Labs/stride/v26/testutil/network"
+)
+
+func ExecuteCLIExpectError(t *testing.T, cmd *cobra.Command, args []string, errorString string) {
+	sdk.GetConfig().SetBech32PrefixForAccount("stride", "stridepub")
+
+	clientCtx := client.Context{}.
+		WithFromAddress(sdk.MustAccAddressFromBech32("stride10p3xzmnpdeshqctsv9ukzcm0vdhkuat52aucqd")).
+		WithCodec(network.DefaultConfig().Codec)
+
+	_, err := clitestutil.ExecTestCLICmd(clientCtx, cmd, args)
+	require.ErrorContains(t, err, errorString)
+}

x/stakeibc/client/cli/gov_test.go

@@ -0,0 +1,112 @@
+package cli_test
+
+import (
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/Stride-Labs/stride/v26/x/stakeibc/client/cli"
+)
+
+func TestCmdAddValidatorsProposal(t *testing.T) {
+	t.Run("no file", func(t *testing.T) {
+		args := []string{
+			"[proposal-file]",
+		}
+
+		cmd := cli.CmdAddValidatorsProposal()
+		ExecuteCLIExpectError(t, cmd, args, `open [proposal-file]: no such file or directory`)
+	})
+	t.Run("empty file", func(t *testing.T) {
+		f, err := os.CreateTemp("", "")
+		require.NoError(t, err)
+		defer f.Close()
+
+		args := []string{
+			f.Name(),
+		}
+
+		cmd := cli.CmdAddValidatorsProposal()
+		ExecuteCLIExpectError(t, cmd, args, `EOF`)
+	})
+	t.Run("non json file", func(t *testing.T) {
+		f, err := os.CreateTemp("", "")
+		require.NoError(t, err)
+		defer f.Close()
+		_, err = f.WriteString("This is not JSON")
+		require.NoError(t, err)
+
+		args := []string{
+			f.Name(),
+		}
+
+		cmd := cli.CmdAddValidatorsProposal()
+		ExecuteCLIExpectError(t, cmd, args, `invalid character 'T' looking for beginning of value`)
+	})
+	t.Run("wrong json format", func(t *testing.T) {
+		f, err := os.CreateTemp("", "")
+		require.NoError(t, err)
+		defer f.Close()
+		_, err = f.WriteString(`{"description":"Proposal to add Imperator because they contribute in XYZ ways!","hostZone":"GAIA","blabla_validators":[{"name":"Imperator","address":"cosmosvaloper1v5y0tg0jllvxf5c3afml8s3awue0ymju89frut"}],"deposit":"64000000ustrd"}`)
+		require.NoError(t, err)
+
+		args := []string{
+			f.Name(),
+		}
+
+		cmd := cli.CmdAddValidatorsProposal()
+		ExecuteCLIExpectError(t, cmd, args, `unknown field "blabla_validators" in types.AddValidatorsProposal`)
+	})
+}
+
+func TestCmdToggleLSMProposal(t *testing.T) {
+	t.Run("no file", func(t *testing.T) {
+		args := []string{
+			"[proposal-file]",
+		}
+
+		cmd := cli.CmdToggleLSMProposal()
+		ExecuteCLIExpectError(t, cmd, args, `open [proposal-file]: no such file or directory`)
+	})
+	t.Run("empty file", func(t *testing.T) {
+		f, err := os.CreateTemp("", "")
+		require.NoError(t, err)
+		defer f.Close()
+
+		args := []string{
+			f.Name(),
+		}
+
+		cmd := cli.CmdToggleLSMProposal()
+		ExecuteCLIExpectError(t, cmd, args, `EOF`)
+	})
+	t.Run("non json file", func(t *testing.T) {
+		f, err := os.CreateTemp("", "")
+		require.NoError(t, err)
+		defer f.Close()
+		_, err = f.WriteString("This is not JSON")
+		require.NoError(t, err)
+
+		args := []string{
+			f.Name(),
+		}
+
+		cmd := cli.CmdToggleLSMProposal()
+		ExecuteCLIExpectError(t, cmd, args, `invalid character 'T' looking for beginning of value`)
+	})
+	t.Run("wrong json format", func(t *testing.T) {
+		f, err := os.CreateTemp("", "")
+		require.NoError(t, err)
+		defer f.Close()
+		_, err = f.WriteString(`{"description":"Proposal to add Imperator because they contribute in XYZ ways!","hostZone":"GAIA","blabla_validators":[{"name":"Imperator","address":"cosmosvaloper1v5y0tg0jllvxf5c3afml8s3awue0ymju89frut"}],"deposit":"64000000ustrd"}`)
+		require.NoError(t, err)
+
+		args := []string{
+			f.Name(),
+		}
+
+		cmd := cli.CmdToggleLSMProposal()
+		ExecuteCLIExpectError(t, cmd, args, `unknown field "blabla_validators" in types.ToggleLSMProposal`)
+	})
+}

x/stakeibc/client/cli/tx.go

@@ -331,7 +331,16 @@ func CmdAddValidators() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "add-validators [host-zone] [validator-list-file]",
 		Short: "Broadcast message add-validators",
-		Args:  cobra.ExactArgs(2),
+		Long: strings.TrimSpace(
+			`Add validators and weights using a JSON file in the following format
+	{
+		"validator_weights": [
+			{"address": "cosmosXXX", "weight": 1},
+			{"address": "cosmosXXX", "weight": 2}
+		]
+	}	
+`),
+		Args: cobra.ExactArgs(2),
 		RunE: func(cmd *cobra.Command, args []string) (err error) {
 			hostZone := args[0]
 			validatorListProposalFile := args[1]