WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit 3ab22d6

Browse files
committed
chore: apply PR feedback
1 parent 425c1c4 commit 3ab22d6

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

lib/unleash/backup_file_reader.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
require 'unleash/configuration'
2-
require 'json'
32

43
module Unleash
54
class BackupFileReader
@@ -15,11 +14,6 @@ def self.read!
1514
Unleash.logger.error "Unable to read the backup_file: #{e}"
1615
# :nocov:
1716
nil
18-
rescue JSON::ParserError => e
19-
# :nocov:
20-
Unleash.logger.error "Unable to parse JSON from existing backup_file: #{e}"
21-
# :nocov:
22-
nil
2317
rescue StandardError => e
2418
# :nocov:
2519
Unleash.logger.error "Unable to extract valid data from backup_file. Exception thrown: #{e}"

lib/unleash/streaming_client_executor.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def initialize(name, engine)
2121
read_backup_file!(engine)
2222
end
2323
rescue StandardError => e
24-
# fail back to reading the backup file
24+
# fall back to reading the backup file
2525
Unleash.logger.warn "StreamingClientExecutor was unable to initialize, attempting to read from backup file."
2626
Unleash.logger.debug "Exception Caught: #{e}"
2727
read_backup_file!(engine)

lib/unleash/toggle_fetcher.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def initialize(engine)
2525
fetch
2626
end
2727
rescue StandardError => e
28-
# fail back to reading the backup file
28+
# fall back to reading the backup file
2929
Unleash.logger.warn "ToggleFetcher was unable to fetch from the network, attempting to read from backup file."
3030
Unleash.logger.debug "Exception Caught: #{e}"
3131
read_backup_file!

0 commit comments

Comments
 (0)