WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Code server patch #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
theramkm wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Code server patch #47

theramkm wants to merge 6 commits into from

Conversation

@theramkm
Copy link

@theramkm theramkm commented Nov 19, 2020 •
edited
Loading

Allows Users to specify code server version. For eg ver 3.7.1 for some reason breaks python extension while 3.5.0 doesn't.

  • updated requirements.txt to pyngrok>=5.0.0 so that pip install requirements work (it was 4.something before).
  • updated version from 0.1.0 -> 0.1.1
  • works in shell version and as an import in the main class.
  • updated readme.

@abhishekkrthakur
Copy link
Owner

abhishekkrthakur commented Nov 19, 2020

we dont need so many changes. If you want to do this, please make one variable CODE_SERVER_VERSION and point it to last stable release. In download use that variable. Only 2 lines of change. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theramkm @abhishekkrthakur