Merge pull request #5760 from ag-grid/ag-16407/fix-fc-performance

AG-16407 - Fix Financial Charts performance.

Author: alantreadway

packages/ag-charts-community/src/chart/axis/axis.ts

@@ -547,18 +547,21 @@ export abstract class Axis<
 
     protected animatable = true;
     setDomains(...domains: DomainWithMetadata<D>[]) {
-        let domain: D[];
+        let normalizedDomain: DomainWithMetadata<D>;
         let animatable: boolean;
         if (domains.length > 0) {
-            ({ domain, animatable } = this.scale.normalizeDomains(...domains));
+            const result = this.scale.normalizeDomains(...domains);
+            // After normalization, ordinal time domains are always sorted ascending
+            normalizedDomain = { domain: result.domain, sortMetadata: { sortOrder: 1 } };
+            animatable = result.animatable;
         } else {
             // Series (or all series in a group) hidden
             // There could be multiple axes, so we still consider this to be animatable
-            domain = [];
+            normalizedDomain = { domain: [] };
             animatable = true;
         }
 
-        this.dataDomain = this.normaliseDataDomain(domain);
+        this.dataDomain = this.normaliseDataDomain(normalizedDomain);
 
         if (this.reverse) {
             this.dataDomain.domain.reverse();
@@ -964,8 +967,8 @@ export abstract class Axis<
         return { domain, direction, boundSeries, defaultValue: this.title?.text };
     }
 
-    protected normaliseDataDomain(d: D[]): { domain: D[]; clipped: boolean } {
-        return { domain: [...d], clipped: false };
+    protected normaliseDataDomain(d: DomainWithMetadata<D>): { domain: D[]; clipped: boolean } {
+        return { domain: [...d.domain], clipped: false };
     }
 
     getLayoutState(): AxisLayout {

packages/ag-charts-community/src/chart/axis/categoryAxis.ts

@@ -1,3 +1,4 @@
+import type { DomainWithMetadata } from 'ag-charts-core';
 import { Property, isFiniteNumber } from 'ag-charts-core';
 import type { AgTimeInterval, AgTimeIntervalUnit, DateFormatterStyle, FormatterParams } from 'ag-charts-types';
 
@@ -49,8 +50,8 @@ export class CategoryAxis<
         return false;
     }
 
-    override normaliseDataDomain(domain: Array<string | object>) {
-        return { domain, clipped: false };
+    override normaliseDataDomain(d: DomainWithMetadata<string | object>) {
+        return { domain: d.domain, clipped: false };
     }
 
     protected override updateScale() {

packages/ag-charts-community/src/chart/axis/logAxis.ts

@@ -1,3 +1,4 @@
+import type { DomainWithMetadata } from 'ag-charts-core';
 import { Logger, normalisedExtentWithMetadata } from 'ag-charts-core';
 
 import type { ModuleContext } from '../../module/moduleContext';
@@ -8,16 +9,24 @@ export class LogAxis extends NumberAxis {
     static override readonly className = 'LogAxis';
     static override readonly type = 'log' as const;
 
-    override normaliseDataDomain(d: number[]) {
+    override normaliseDataDomain(d: DomainWithMetadata<number>) {
         const { min, max, preferredMin, preferredMax } = this;
-        const { extent, clipped } = normalisedExtentWithMetadata(d, min, max, preferredMin, preferredMax);
+        const { extent, clipped } = normalisedExtentWithMetadata(
+            d.domain,
+            min,
+            max,
+            preferredMin,
+            preferredMax,
+            undefined,
+            d.sortMetadata?.sortOrder
+        );
 
-        if ((extent[0] < 0 && extent[1] > 0) || (d[0] < 0 && d[1] > 0)) {
+        if ((extent[0] < 0 && extent[1] > 0) || (d.domain[0] < 0 && d.domain[1] > 0)) {
             Logger.warn(
                 `The log axis domain crosses zero, the chart data cannot be rendered. See log axis documentation for more information.`
             );
             return { domain: [], clipped };
-        } else if (extent[0] === 0 || extent[1] === 0 || d[0] === 0 || d[1] === 0) {
+        } else if (extent[0] === 0 || extent[1] === 0 || d.domain[0] === 0 || d.domain[1] === 0) {
             Logger.warn(
                 `The log axis domain contains a value of 0, the chart data cannot be rendered. See log axis documentation for more information.`
             );

packages/ag-charts-community/src/chart/axis/numberAxis.ts

@@ -1,3 +1,4 @@
+import type { DomainWithMetadata } from 'ag-charts-core';
 import { Property, normalisedExtentWithMetadata } from 'ag-charts-core';
 import type { FormatterParams } from 'ag-charts-types';
 
@@ -33,9 +34,17 @@ export class NumberAxis extends CartesianAxis<LinearScale | LogScale, number> {
         return min != null && max != null && min < max;
     }
 
-    override normaliseDataDomain(d: number[]) {
+    override normaliseDataDomain(d: DomainWithMetadata<number>) {
         const { min, max, preferredMin, preferredMax } = this;
-        const { extent, clipped } = normalisedExtentWithMetadata(d, min, max, preferredMin, preferredMax);
+        const { extent, clipped } = normalisedExtentWithMetadata(
+            d.domain,
+            min,
+            max,
+            preferredMin,
+            preferredMax,
+            undefined,
+            d.sortMetadata?.sortOrder
+        );
 
         return { domain: extent, clipped };
     }

packages/ag-charts-community/src/chart/axis/timeAxis.ts

@@ -1,11 +1,10 @@
-import type { ChartAxisDirection } from 'ag-charts-core';
+import type { ChartAxisDirection, DomainWithMetadata } from 'ag-charts-core';
 import {
     BaseProperties,
     Logger,
     Property,
     ProxyPropertyOnWrite,
     dateTruncationForDomain,
-    extractDomain,
     intervalEpoch,
     intervalFloor,
     intervalMilliseconds,
@@ -90,9 +89,9 @@ export class TimeAxis extends CartesianAxis<TimeScale, number | Date> {
         return this.parentLevel.enabled ? this.parentLevel.tick : undefined;
     }
 
-    override normaliseDataDomain(domain: Date[]) {
+    override normaliseDataDomain(d: DomainWithMetadata<Date>) {
         const { extent, clipped } = normalisedTimeExtentWithMetadata(
-            domain,
+            d,
             this.min,
             this.max,
             this.preferredMin,
@@ -199,7 +198,7 @@ export function calculateDefaultUnit(
     for (const series of boundSeries) {
         if (!series.visible) continue;
 
-        const { extent: domain } = normalisedTimeExtentWithMetadata(extractDomain(series.getDomain(direction)));
+        const { extent: domain } = normalisedTimeExtentWithMetadata(series.getDomain(direction));
         if (domain.length === 0) continue;
 
         const d0 = domain[0].valueOf();

packages/ag-charts-community/src/chart/axis/unitTimeAxis.ts

@@ -1,3 +1,4 @@
+import type { DomainWithMetadata } from 'ag-charts-core';
 import {
     Property,
     dateTruncationForDomain,
@@ -91,9 +92,9 @@ export class UnitTimeAxis extends DiscreteTimeAxis<UnitTimeScale> {
         this.scale.interval = this.unit ?? this.defaultUnit;
     }
 
-    override normaliseDataDomain(domain: Date[]) {
+    override normaliseDataDomain(d: DomainWithMetadata<Date>) {
         const { extent, clipped } = normalisedTimeExtentWithMetadata(
-            domain,
+            d,
             this.min,
             this.max,
             this.preferredMin,

packages/ag-charts-community/src/chart/series/cartesian/barSeries.ts

@@ -1314,9 +1314,21 @@ export class BarSeries extends AbstractBarSeries<
         highlightState?: HighlightState
     ): Required<AgBarSeriesStyle> {
         const { properties, dataModel, processedData } = this;
-        const { itemStyler } = properties;
+        const { itemStyler, simpleItemStyler } = properties;
 
         const highlightStyle = this.getHighlightStyle(isHighlight, datumIndex, highlightState);
+
+        // Fast path: simpleItemStyler bypasses options graph resolution
+        if (simpleItemStyler && processedData != null && datumIndex != null) {
+            const datum = processedData.dataSources.get(this.id)?.data?.[datumIndex];
+            const overrides = simpleItemStyler(datum);
+            return mergeDefaults(
+                overrides,
+                highlightStyle,
+                this.getStyle(false, highlightState)
+            ) as Required<AgBarSeriesStyle>;
+        }
+
         let style = mergeDefaults(highlightStyle, this.getStyle(datumIndex === undefined, highlightState));
 
         if (itemStyler && dataModel != null && processedData != null && datumIndex != null) {
@@ -1616,6 +1628,7 @@ export class BarSeries extends AbstractBarSeries<
         return (
             this.properties.styler != null ||
             this.properties.itemStyler != null ||
+            this.properties.simpleItemStyler != null ||
             this.properties.label.itemStyler != null
         );
     }

packages/ag-charts-community/src/chart/series/cartesian/barSeriesOptionsDef.ts

@@ -2,6 +2,7 @@ import {
     type OptionsDefs,
     barHighlightOptionsDef,
     boolean,
+    callback,
     callbackDefs,
     commonSeriesOptionsDefs,
     commonSeriesThemeableOptionsDefs,
@@ -86,3 +87,5 @@ barSeriesOptionsDef.yFilterKey = undocumented(string);
 barSeriesOptionsDef.pickOutsideVisibleMinorAxis = undocumented(boolean);
 // @ts-expect-error undocumented option
 barSeriesOptionsDef.focusPriority = undocumented(number);
+// @ts-expect-error undocumented option
+barSeriesOptionsDef.simpleItemStyler = undocumented(callback);

packages/ag-charts-community/src/chart/series/cartesian/barSeriesProperties.ts

@@ -80,6 +80,9 @@ export class BarSeriesProperties extends AbstractBarSeriesProperties<AgBarSeries
     @Property
     itemStyler?: Styler<AgBarSeriesItemStylerParams<unknown>, AgBarSeriesStyle>;
 
+    @Property
+    simpleItemStyler?: (datum: unknown) => AgBarSeriesStyle | undefined;
+
     @Property
     readonly shadow = new DropShadow();
 

packages/ag-charts-community/src/scale/ordinalTimeScale.ts

@@ -76,7 +76,13 @@ export class OrdinalTimeScale extends DiscreteTimeScale {
 
         if (nonEmptyDomains.length === 0) {
             return { domain: [], animatable: false };
-        } else if (nonEmptyDomains.length === 1) {
+        }
+
+        // Check if all domains are the same array reference (common in Financial Charts)
+        const firstDomain = nonEmptyDomains[0].domain;
+        const allSame = nonEmptyDomains.every((d) => d.domain === firstDomain);
+
+        if (nonEmptyDomains.length === 1 || allSame) {
             const input = nonEmptyDomains[0];
             let domain = input.domain;