WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit dd9fdf5

Browse files
authored
Transform TextInput to es6 class (#5805)
* transform to es6 class * generate types after merge * rename AriaOptions to TextInputAriaOptions for clarity
1 parent b45e94c commit dd9fdf5

File tree

5 files changed

+848
-722
lines changed

5 files changed

+848
-722
lines changed

ace-internal.d.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ export namespace Ace {
3232
type HoverTooltip = import("ace-code/src/tooltip").HoverTooltip;
3333
type Tooltip = import("ace-code/src/tooltip").Tooltip;
3434
type PopupManager = import("ace-code/src/tooltip").PopupManager;
35+
type TextInput = import("ace-code/src/keyboard/textinput").TextInput;
3536

3637
type AfterLoadCallback = (err: Error | null, module: unknown) => void;
3738
type LoaderFunction = (moduleName: string, afterLoad: AfterLoadCallback) => void;
@@ -967,12 +968,6 @@ export namespace Ace {
967968
new(session: EditSession): Selection;
968969
}
969970

970-
interface TextInput {
971-
resetSelection(): void;
972-
973-
setAriaOption(options?: { activeDescendant: string, role: string, setLabel: any }): void;
974-
}
975-
976971
type CompleterCallback = (error: any, completions: Completion[]) => void;
977972

978973
interface Completer {
@@ -1292,6 +1287,13 @@ export namespace Ace {
12921287
export interface ScrollbarEvents {
12931288
"scroll": (e: { data: number }) => void;
12941289
}
1290+
1291+
export interface TextInputAriaOptions {
1292+
activeDescendant?: string;
1293+
role?: string;
1294+
setLabel?: boolean;
1295+
inline?: boolean;
1296+
}
12951297
}
12961298

12971299

ace.d.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ declare module "ace-code" {
4141
type HoverTooltip = import("ace-code/src/tooltip").HoverTooltip;
4242
type Tooltip = import("ace-code/src/tooltip").Tooltip;
4343
type PopupManager = import("ace-code/src/tooltip").PopupManager;
44+
type TextInput = import("ace-code/src/keyboard/textinput").TextInput;
4445
type AfterLoadCallback = (err: Error | null, module: unknown) => void;
4546
type LoaderFunction = (moduleName: string, afterLoad: AfterLoadCallback) => void;
4647
export interface ConfigOptions {
@@ -775,14 +776,6 @@ declare module "ace-code" {
775776
var Selection: {
776777
new(session: EditSession): Selection;
777778
};
778-
interface TextInput {
779-
resetSelection(): void;
780-
setAriaOption(options?: {
781-
activeDescendant: string;
782-
role: string;
783-
setLabel: any;
784-
}): void;
785-
}
786779
type CompleterCallback = (error: any, completions: Completion[]) => void;
787780
interface Completer {
788781
identifierRegexps?: Array<RegExp>;
@@ -1032,6 +1025,12 @@ declare module "ace-code" {
10321025
data: number;
10331026
}) => void;
10341027
}
1028+
export interface TextInputAriaOptions {
1029+
activeDescendant?: string;
1030+
role?: string;
1031+
setLabel?: boolean;
1032+
inline?: boolean;
1033+
}
10351034
}
10361035
export const config: typeof import("ace-code/src/config");
10371036
export function edit(el?: string | (HTMLElement & {

src/editor.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -906,7 +906,7 @@ class Editor {
906906

907907
/**
908908
*
909-
* @param {string | string[]} command
909+
* @param {string | string[] | import("../ace-internal").Ace.Command} command
910910
* @param [args]
911911
* @return {boolean}
912912
*/

0 commit comments

Comments
 (0)