WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Add functionality for handling metrics and output shapes #937

@sgreenbury

Description

@sgreenbury

As introduced in #924 and to be extended in #906, the metrics will be returnable without reduction by mean across all dims.

For MSLL the metric returns through reshaping the output to the original shape.

It would be preferable to instead ensure the correct shape is returned.

An option for this is to use the similar approach with the ._fit() and ._predict() methods in Emulator and introduce a ._call() for metric that can be subclassesd by abstract but with the __call__ potentially calling another function to ensure correct shapes given aggregation method that is passed.

This issue might be best addressed as part of #906 but opening an issue in case it's implemented separately.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    📋 Product backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions