Merge pull request #30 from aminya/hydration-fix

Author: aminya

package.json

@@ -24,18 +24,18 @@
   },
   "prettier": "prettier-config-atomic",
   "devDependencies": {
-    "@types/node": "^20.11.24",
-    "cspell": "^8.5.0",
+    "@types/node": "^20.11.30",
+    "cspell": "^8.6.0",
     "eslint": "^8.57.0",
-    "eslint-config-atomic": "^1.20.6",
-    "npm-check-updates": "^16.14.15",
+    "eslint-config-atomic": "^1.21.2",
+    "npm-check-updates": "^16.14.17",
     "npm-run-all2": "^6.1.2",
     "prettier": "3.2.5",
     "prettier-config-atomic": "^4.0.0",
     "readme-md-generator": "^1.0.0",
     "shx": "^0.3.4",
     "ts-readme": "^1.1.3",
-    "typescript": "^5.3.3",
+    "typescript": "^5.4.3",
     "typesync": "^0.12.1"
   },
   "engines": {

packages/astro-htmlnano/package.json

@@ -15,13 +15,13 @@
   },
   "dependencies": {
     "astro-posthtml": "workspace:*",
-    "cssnano": "^6.0.5",
+    "cssnano": "^6.1.1",
     "htmlnano": "2.1.0",
-    "postcss": "^8.4.35",
+    "postcss": "^8.4.38",
     "relateurl": "^0.2.7",
     "srcset": "^5.0.1",
     "svgo": "^3.2.0",
-    "terser": "^5.28.1"
+    "terser": "^5.29.2"
   },
   "devDependencies": {
     "@types/relateurl": "^0.2.33"

packages/astro-htmlnano/src/index.ts

@@ -20,7 +20,17 @@ import htmlnano, { type HtmlnanoOptions, type Presets } from "htmlnano/index.mjs
  */
 export function getAstroHTMLNano(options?: HtmlnanoOptions, preset?: Presets[keyof Presets]) {
   if (process.env.NODE_ENV === "production") {
-    return (_context: APIContext, next: MiddlewareNext) => getAstroPostHTML([htmlnano(options, preset)])(_context, next)
+    return (_context: APIContext, next: MiddlewareNext) => {
+      const htmlnanoOptions: HtmlnanoOptions = options ?? {}
+
+      // disable `removeComments` due to Astro's use of comments for hydration
+      if (htmlnanoOptions.removeComments) {
+        console.warn("`removeComments` is disabled due to Astro's use of comments for hydration.")
+      }
+      htmlnanoOptions.removeComments = false
+
+      return getAstroPostHTML([htmlnano(htmlnanoOptions, preset)])(_context, next)
+    }
   }
   return (_context: APIContext, next: MiddlewareNext) => next()
 }