`ProjectBaseOptions` improper uri tag for `Skip` field

[xobotyi]

As for documentation, during request to projects list Skip option has to be passed as S (capital S), instead of lowercased, is it is now.

Source: API docs
Affected version: 3.7+

[andygrunwald]

Hey @xobotyi,

I am not sure if this is a bug.

For the endpoint List Projects - 'GET /projects/', it is a capital S. See https://gerrit-review.googlesource.com/Documentation/rest-api-projects.html and

Example code:

opt := &gerrit.ProjectOptions{
	Skip: 1,
	ProjectBaseOptions: gerrit.ProjectBaseOptions{
		Limit: 5,
	},
}
list, _, err := client.Projects.ListProjects(context.Background(), opt)
if err != nil {
	panic(err)
}
for _, project := range *list {
	fmt.Printf("Project: %s\n", project.Name)
}

For the endpoint List Tags -- 'GET /projects/{project-name}/tags/', it is a small s

Example code:

optBase := &gerrit.ProjectBaseOptions{
	Skip:  0,
	Limit: 5,
}
tags, _, err := client.Projects.ListTags(context.Background(), "AhoCorasick", optBase)
if err != nil {
	panic(err)
}
for _, tag := range *tags {
	fmt.Printf("Tag: %s %s\n", tag.Ref, tag.Object)
}

Can you confirm it?

@dmitshur How do you see it?

[andygrunwald]

Actually, it also works with an uppercase S. Here, the documentation might be misleading. Sometimes a S and sometimes a s is used.