Fix/installment offer code persistence #2249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashranaway
commented
Dec 8, 2025
Comment on lines
+19
to
+51
|
|
||
| def has_original_offer_code? | ||
| original_offer_code_id.present? && (original_offer_code_amount_cents.present? || original_offer_code_amount_percentage.present?) | ||
| end | ||
|
|
||
| def original_offer_code_amount_off(price_cents) | ||
| return 0 if !has_original_offer_code? | ||
| return original_offer_code_amount_cents if !original_offer_code_is_percent? | ||
|
|
||
| (price_cents * (original_offer_code_amount_percentage / 100.0)).round | ||
| end | ||
|
|
||
| def original_offer_code_display_code | ||
| original_offer_code_code | ||
| end | ||
|
|
||
| def displayed_amount_off(currency_type, with_symbol: false) | ||
| return nil unless has_original_offer_code? | ||
|
|
||
| if with_symbol | ||
| if original_offer_code_is_percent? | ||
| "#{original_offer_code_amount_percentage}%" | ||
| else | ||
| Money.new(original_offer_code_amount_cents, currency_type).format(no_cents_if_whole: true, symbol: true) | ||
| end | ||
| else | ||
| if original_offer_code_is_percent? | ||
| original_offer_code_amount_percentage | ||
| else | ||
| Money.new(original_offer_code_amount_cents, currency_type).format(no_cents_if_whole: true, symbol: false) | ||
| end | ||
| end | ||
| end |
Contributor
Author
There was a problem hiding this comment.
removed association, added display methods
yashranaway
commented
Dec 8, 2025
Contributor
Author
There was a problem hiding this comment.
updated set_price_and_rate and original_offer_code
yashranaway
commented
Dec 8, 2025
Comment on lines
+61
to
+75
| } | ||
|
|
||
| if purchase.offer_code.present? | ||
| snapshot_attrs.merge!( | ||
| original_offer_code_id: purchase.offer_code.id, | ||
| original_offer_code_amount_cents: purchase.offer_code.amount_cents, | ||
| original_offer_code_amount_percentage: purchase.offer_code.amount_percentage, | ||
| original_offer_code_is_percent: purchase.offer_code.is_percent?, | ||
| original_offer_code_duration_in_months: purchase.offer_code.duration_in_months, | ||
| original_offer_code_code: purchase.offer_code.code, | ||
| original_offer_code_currency: purchase.offer_code.currency_type | ||
| ) | ||
| end | ||
|
|
||
| payment_option.build_installment_plan_snapshot(snapshot_attrs) |
Contributor
Author
There was a problem hiding this comment.
snapshot now includes offer code fields
yashranaway
commented
Dec 8, 2025
Contributor
Author
|
@EmCousin _a added updates as per #2237 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1410
Previous PR #2075 & #2237
What
Stores offer code discount terms directly in InstallmentPlanSnapshot so installment payments retain their original discount even if the offer code is deleted, expired, or modified.
Changes
belongs_to :original_offer_codeassociation - no longer relies on live offer codeset_price_and_rateprioritizes snapshot data for installment paymentsOnetime::BackfillPaymentOptionInstallmentSnapshotsto include offer code data when creating snapshotsOnetime::BackfillOfferCodeFieldsToInstallmentSnapshotsto update existing snapshots missing offer code dataTests
AI disclosure
Used Claude Opus 4.5 via Cursor for implementation.
All code was manually reviewed and verified.
Notes
I’ve watched all the Antiwork livestreams