[fix](filecache) dedup need_update_lru_block queue to reduce memory consumption #58903
+264
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this queue contains large amount of duplicated items dedup this queue to shrink memory. orders are updated in batch and ignore internal orders within a batch. Signed-off-by: zhengyu <[email protected]>
freemandealer
requested review from
dataroaring and
gavinchou
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
gavinchou
reviewed
Dec 10, 2025
| if (drained >= limit) { | ||
| break; | ||
| } | ||
| std::lock_guard lock(shard.mutex); |
Contributor
There was a problem hiding this comment.
why not just "drain" the entire shard instead of draining one by one.
we dont actually care about the order here.
Contributor
Author
There was a problem hiding this comment.
because we want release the _mutex for a while if the for loop takes too long.
gavinchou
reviewed
Dec 10, 2025
gavinchou
reviewed
Dec 10, 2025
|
|
||
| struct Shard { | ||
| std::mutex mutex; | ||
| std::unordered_map<FileBlock*, FileBlockSPtr> entries; |
Contributor
There was a problem hiding this comment.
do we need sharedptr to keep reference of file block?
Contributor
Author
There was a problem hiding this comment.
yes we do for safety reasons
gavinchou
reviewed
Dec 10, 2025
TPC-H: Total hot run time: 35373 ms |
TPC-DS: Total hot run time: 180912 ms |
ClickBench: Total hot run time: 27.17 s |
Signed-off-by: zhengyu <[email protected]>
Signed-off-by: freemandealer <[email protected]>
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35346 ms |
TPC-DS: Total hot run time: 181016 ms |
ClickBench: Total hot run time: 27.71 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run cloud_p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
approved these changes
Dec 12, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this queue contains large amount of duplicated items dedup this queue to shrink memory. orders are updated in batch and ignore internal orders within a batch.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)