WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit f7b2ba0

Browse files
committed
In tools/dist/release.py, do not try to update the Buildbot config when
creating a release branch. According to [1], we no longer use that Buildbot job. * tools/dist/release.py (buildbot_repos): Remove. (get_buildbot_wc_path): Remove. (update_buildbot_config): Remove. (create_release_branch): No longer call update_buildbot_config(). (main): Update description for the `create-release-branch` command. [1]: https://lists.apache.org/thread/wnymzy0ck0ygon95jnd1x28ltr6z0kxh git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1930869 13f79535-47bb-0310-9956-ffa450edef68
1 parent 0586552 commit f7b2ba0

File tree

1 file changed

+1
-34
lines changed

1 file changed

+1
-34
lines changed

tools/dist/release.py

Lines changed: 1 addition & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@ def get_dist_metadata_file_path():
9696
dist_dev_url = dist_repos + '/dev/subversion'
9797
dist_release_url = dist_repos + '/release/subversion'
9898
dist_archive_url = 'https://archive.apache.org/dist/subversion'
99-
buildbot_repos = os.getenv('SVN_RELEASE_BUILDBOT_REPOS',
100-
'https://svn.apache.org/repos/infra/infrastructure/buildbot2')
10199
extns = ['zip', 'tar.gz', 'tar.bz2']
102100

103101

@@ -512,11 +510,6 @@ def get_trunk_wc_path(base_dir, path=None):
512510
if path is None: return trunk_wc_path
513511
return os.path.join(trunk_wc_path, path)
514512

515-
def get_buildbot_wc_path(base_dir, path=None):
516-
buildbot_wc_path = os.path.join(get_tempdir(base_dir), 'svn-buildmaster')
517-
if path is None: return buildbot_wc_path
518-
return os.path.join(buildbot_wc_path, path)
519-
520513
def get_trunk_url(revnum=None):
521514
return svn_repos + '/trunk' + '@' + (str(revnum) if revnum else '')
522515

@@ -669,37 +662,12 @@ def update_backport_bot(args):
669662
670663
""" % (ver.branch,))
671664

672-
#----------------------------------------------------------------------
673-
def update_buildbot_config(args):
674-
"""Add the new branch to the list of branches monitored by the buildbot
675-
master.
676-
"""
677-
ver = args.version
678-
buildbot_wc = get_buildbot_wc_path(args.base_dir)
679-
run_svn(['checkout', buildbot_repos, buildbot_wc])
680-
681-
prev_ver = Version('1.%d.0' % (ver.minor - 1,))
682-
next_ver = Version('1.%d.0' % (ver.minor + 1,))
683-
684-
relpath = 'projects/subversion.py'
685-
edit_file(get_buildbot_wc_path(args.base_dir, relpath),
686-
r'(MINOR_LINES = \[.*%s)(\])' % (prev_ver.minor,),
687-
r'\1, %s\2' % (ver.minor,))
688-
689-
log_msg = '''\
690-
Subversion: start monitoring the %s branch.
691-
''' % (ver.branch)
692-
commit_paths = [get_buildbot_wc_path(args.base_dir, relpath)]
693-
run_svn(['commit'] + commit_paths + ['-m', log_msg],
694-
dry_run=args.dry_run)
695-
696665
#----------------------------------------------------------------------
697666
def create_release_branch(args):
698667
make_release_branch(args)
699668
update_minor_ver_in_trunk(args)
700669
create_status_file_on_branch(args)
701670
update_backport_bot(args)
702-
update_buildbot_config(args)
703671

704672

705673
#----------------------------------------------------------------------
@@ -1752,8 +1720,7 @@ def main():
17521720
subparser = subparsers.add_parser('create-release-branch',
17531721
help='''Create a minor release branch: branch from trunk,
17541722
update version numbers on trunk, create status
1755-
file on branch, update backport bot,
1756-
update buildbot config.''')
1723+
file on branch, update backport bot.''')
17571724
subparser.set_defaults(func=create_release_branch)
17581725
subparser.add_argument('version', type=Version,
17591726
help='''A version number to indicate the branch, such as

0 commit comments

Comments
 (0)