WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit 2f64d0b

Browse files
committed
Handled to ensure that default value will be 160 and 24 respectively if the user ever clears the input fields.
1 parent 6db3822 commit 2f64d0b

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

app/client/src/pages/AdminSettings/Branding/SettingsForm.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,7 @@ function SettingsForm(props: SettingsFormProps) {
132132
<NumberInput
133133
className="t--settings-brand-logo-width-input"
134134
onChange={(val) => {
135-
const numVal = val ? parseInt(val, 10) : undefined;
136-
137-
onChange(isNaN(numVal as number) ? undefined : numVal);
135+
onChange(val ? parseInt(val, 10) : 160);
138136
AnalyticsUtil.logEvent("BRANDING_PROPERTY_UPDATE", {
139137
propertyName: "logoWidth",
140138
});
@@ -161,9 +159,7 @@ function SettingsForm(props: SettingsFormProps) {
161159
<NumberInput
162160
className="t--settings-brand-logo-height-input"
163161
onChange={(val) => {
164-
const numVal = val ? parseInt(val, 10) : undefined;
165-
166-
onChange(isNaN(numVal as number) ? undefined : numVal);
162+
onChange(val ? parseInt(val, 10) : 24);
167163
AnalyticsUtil.logEvent("BRANDING_PROPERTY_UPDATE", {
168164
propertyName: "logoHeight",
169165
});

0 commit comments

Comments
 (0)