WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit 5cf3dcd

Browse files
committed
Made changes to reuse the DataSidePane. Removed the urls in RouteBuilders as its taken care by integrationEditorURL and datasourcesEditorURL functions.
1 parent 097c655 commit 5cf3dcd

File tree

4 files changed

+3
-242
lines changed

4 files changed

+3
-242
lines changed

app/client/src/ce/RouteBuilder.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -197,22 +197,6 @@ export const queryAddURL = (props: URLBuilderParams): string =>
197197
suffix: `queries/add`,
198198
});
199199

200-
export const workspaceDatasourceEditorURL = (
201-
props: URLBuilderParams & {
202-
datasourceId: string;
203-
},
204-
): string =>
205-
urlBuilder.build({
206-
...props,
207-
suffix: `datasource/${props.datasourceId}`,
208-
});
209-
210-
export const workspaceDatasourcesNewURL = (props: URLBuilderParams): string =>
211-
urlBuilder.build({
212-
...props,
213-
suffix: "datasources/NEW",
214-
});
215-
216200
export const appLibrariesURL = (): string =>
217201
urlBuilder.build({
218202
suffix: "libraries",

app/client/src/pages/Editor/DataSidePane/DataSidePane.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const DatasourceIcon = styled.img`
4747
`;
4848

4949
interface DataSidePaneProps {
50-
dsUsageMap: Record<string, string>;
50+
dsUsageMap?: Record<string, string>;
5151
}
5252

5353
export const DataSidePane = (props: DataSidePaneProps) => {

app/client/src/pages/workspace/WorkspaceDataSidePane.tsx

Lines changed: 0 additions & 221 deletions
This file was deleted.

app/client/src/pages/workspace/WorkspaceDatasourcesPage.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ import styled from "styled-components";
66
import { Spinner, IDE_HEADER_HEIGHT } from "@appsmith/ads";
77
import CenteredWrapper from "components/designSystems/appsmith/CenteredWrapper";
88
import { GridContainer } from "IDE/Components/LayoutComponents";
9-
10-
// Import the workspace-adapted DataSidePane
11-
import { WorkspaceDataSidePane } from "./WorkspaceDataSidePane";
9+
import { DataSidePane } from "pages/Editor/DataSidePane/DataSidePane";
1210
import CreateNewDatasourceTab from "pages/Editor/IntegrationEditor/CreateNewDatasourceTab";
1311
import WorkspaceDatasourceEditor from "./WorkspaceDatasourceEditor";
1412
import DatasourceBlankState from "pages/Editor/DataSourceEditor/DatasourceBlankState";
@@ -101,7 +99,7 @@ export const WorkspaceDatasourcesPage = (
10199
}}
102100
>
103101
<LeftPane>
104-
<WorkspaceDataSidePane workspaceId={workspaceId} />
102+
<DataSidePane />
105103
</LeftPane>
106104
<MainPane>
107105
<Switch>

0 commit comments

Comments
 (0)