27/10 Daily Promotion #41319
Merged
27/10 Daily Promotion #41319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# PR Description ## Summary Fixes an issue where `basePageId` could be undefined during initial page load or navigation, causing errors in the URL builder. ## Changes - Added fallback to `null` for `basePageId` in Header component when undefined - Wrapped `urlBuilderFn` call in try-catch block to gracefully handle missing `basePageId` - Returns empty string for href when `basePageId` is not yet available ## Why During initial page load or navigation transitions, `currentPage?.basePageId` may not be available yet, which could cause the URL builder to throw errors. This change ensures the application handles this edge case gracefully by providing a fallback value and catching any errors that may occur. ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/18742901184> > Commit: 48dc01a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=18742901184&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Thu, 23 Oct 2025 09:48:19 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No
…rtially enabled (#41317) ## Description Fixed a logic gap in the Applications page where no applications would be displayed when `isAiAgentInstanceEnabled` is true but `isAiAgentFlowEnabled` is false. ## Changes - Updated conditional rendering logic for application lists to handle all combinations of AI agent feature flags - Non-anvil applications now display when either flag is disabled: `(!isAiAgentInstanceEnabled || !isAiAgentFlowEnabled)` - Anvil applications (AI agents) now only display when both flags are enabled: `isAiAgentFlowEnabled && isAiAgentInstanceEnabled` ## Problem Previously, when `isAiAgentInstanceEnabled` was `true` and `isAiAgentFlowEnabled` was `false`, neither ApplicationCardList component would render, resulting in no applications being shown to the user. ### Logic Gap: - First list: `!isAiAgentInstanceEnabled` → evaluates to `false`, doesn't render - Second list: `isAiAgentFlowEnabled` → evaluates to `false`, doesn't render - Result: No applications displayed ## Solution Updated the conditions to ensure at least one list always renders based on the flag states: - Regular applications display unless both AI flags are enabled - AI agent applications only display when both flags are enabled ## Testing - [ ] Verified applications display when both flags are false - [ ] Verified applications display when `isAiAgentInstanceEnabled` is true but `isAiAgentFlowEnabled` is false - [ ] Verified both application types display correctly when both flags are true - [ ] Verified AI agent applications only when both flags are enabled ## Files Changed - `app/client/src/ce/pages/Applications/index.tsx` Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Enhanced application availability by refining the logic that determines which application card lists are displayed based on different system configuration combinations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?