18/11 - Daily Promotion #41394
Merged
18/11 - Daily Promotion #41394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#41362) ## Description EE PR: appsmithorg/appsmith-ee#8275 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/19130353944> > Commit: 01f27c3 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=19130353944&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 06 Nov 2025 10:08:51 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Bulk refactoring and update flows now process many actions/collections together for lower latency and fewer DB operations. * Cache-aware refactor validation speeds repeated name checks and reduces lookups. * Refactor metadata tracking made thread-safe. * **New Features** * New unsupported bulk update paths for actions and action collections to support faster migrations and maintenance. * **Tests** * Added mocks and coverage for bulk fetch/update scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Added cypress test cases to validate page slug and application slug persistence flows. We are also validating the deployed application to ascertain if the static url work after being enabled and routes deleted after it has being disabled. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Settings" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/19159763732> > Commit: c6771d6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=19159763732&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Settings` > Spec: > <hr>Fri, 07 Nov 2025 06:29:12 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Static URL is enabled by default: apps and pages get auto-generated, editable slugs with live validation, URL preview, persistence across reloads, and deploy-time routing. * **Tests** * Added end-to-end coverage for slug generation, editing, validation, persistence, cancellation, disable/reenable flows, and deployed-route behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…e appsmith.ui state object (#41339) ## Description Introducing this property as part of appsmith.ui state object, so that it can be used in cases like passing to a custom widget which can help in determining height of the widget with respective to the App's visible height Example of usage below: https://github.com/user-attachments/assets/b19914f9-2248-453f-bbc8-a903f1034210 Additional Info: Controlling this by a feature flag only at the selector level. Could not do it at the component level as one of the dispatch action occurs from a class based component that does not support hooks like useFeatureFlag > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/19159166010> > Commit: 134a977 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=19159166010&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 07 Nov 2025 06:39:25 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added viewport dimension tracking (height & width) across the app. * Window dimensions are available in app state and exposed in the data tree for use in responsive logic and bindings. * Initial dimensions are captured on app load so widgets and pages can react to current viewport size (feature guarded by a rollout flag). <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Disable cache for the base image build. This job doesn't need to be fast and sometimes we're not picking up CVE fixes as quickly as we could because layers are cached for a while. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated CI/CD pipeline to ensure fresh package dependencies on each build cycle. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description The currency input widget has formatting issues for languages that use ',' as decimal separator. Following is the explanation of the behavior & expected When the user sets the value using `defaultValue` or `setValue` for this widget. And the value is 12.33 (here . represents decimal) Then the widget shows 12.33, but it should show 12,33 (because language of the browser is set to portugese; "," is decimal) When the widget shows 12.33 (here . is not decimal) And the user focuses on the widget Then the widget shows 1233 (because, in portugese . is not decimal) When the widget is focused And it shows 1233 And the user clicks to defocus it Then the currency changes to 1.233 (because, in portugese . is not decimal) When the value of currency widget is set to 12.33 (. is decimal) Then the `<widgetName>.value` should always be 12.33 (. is decimal) BECAUSE this is actually computed value When the user inputs 12,33 (, is decimal) Then the `<widgetName>.value` should always be 12.33 (. is decimal) BECAUSE this is actually computed value <img width="866" height="306" alt="Screenshot 2025-11-11 at 7 15 22 PM" src="https://github.com/user-attachments/assets/fe9e739f-be22-42fc-8c52-e2922495239d" /> <img width="796" height="269" alt="Screenshot 2025-11-11 at 7 15 46 PM" src="https://github.com/user-attachments/assets/6ebe8e3f-fa79-4b26-937b-4f58eaebdb98" /> <img width="826" height="228" alt="Screenshot 2025-11-11 at 7 43 00 PM" src="https://github.com/user-attachments/assets/2c0c403b-55ed-4558-9b06-3ceadc22fd6c" /> <img width="848" height="262" alt="Screenshot 2025-11-12 at 3 25 26 PM" src="https://github.com/user-attachments/assets/7fc74256-8cd4-49d9-9b50-7d3b3bc865db" /> Fixes - #39583 - #21218 ## Automation /ok-to-test tags="@tag.CurrencyInput,@tag.Widget" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/19293503615> > Commit: cab318c > Workflow: `PR Automation test suite` > Tags: `@tag.CurrencyInput,@tag.Widget` > Spec: `` > <hr>Wed, 12 Nov 2025 10:00:28 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed currency input formatting for programmatically set values. Currency inputs now properly display according to your browser's locale format (e.g., comma decimal separator in Portuguese, period in English) when initially populated. * **Chores** * Updated version control ignore patterns. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: rangrik <[email protected]>
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/19427681426> > Commit: 0424207 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=19427681426&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Mon, 17 Nov 2025 12:08:48 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved artifact data consistency during Git pull and publish operations, ensuring proper synchronization of artifact state across workflows. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
shadabbuchh
requested review from
a team,
nidhi-nair and
sharat87
as code owners
shadabbuchh
requested review from
rahulbarwal
and removed request for
a team
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Failed server tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?