chore: drop support for node 18 and below. drop many testing related dev dependencies and use native node test runner

Author: filmaj

.github/workflows/build.yml

@@ -15,7 +15,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [ 16.x, 18.x, 20.x ]
+        node-version: [ 20.x, 22.x ]
         os: [ windows-latest, ubuntu-latest, macOS-latest ]
 
     # Go
@@ -46,22 +46,15 @@ jobs:
     - name: Install
       run: npm install
 
-    - name: Test (Node.js <= 16.x only)
-      if: matrix.node-version <= '16.x'
-      run: npm run test:nolint
-      env:
-        CI: true
-
     - name: Test
-      if: matrix.node-version > '16.x'
       run: npm test
       env:
         CI: true
 
     - name: Notify
       uses: sarisia/actions-status-discord@v1
       # Only fire alert once
-      if: github.ref == 'refs/heads/main' && failure() && matrix.node-version == '20.x' && matrix.os == 'ubuntu-latest'
+      if: github.ref == 'refs/heads/main' && failure() && matrix.node-version == '22.x' && matrix.os == 'ubuntu-latest'
       with:
         webhook: ${{ secrets.DISCORD_WEBHOOK }}
         title: "build and test"

changelog.md

@@ -2,6 +2,14 @@
 
 ---
 
+## [8.0.0] 2025-04-06
+
+### Changed
+
+- Breaking change: dropped node 16, 18 support
+
+---
+
 ## [7.0.0 - 7.0.1] 2024-01-08
 
 ### Changed

package.json

@@ -7,17 +7,16 @@
     "deno:test": "deno test -A --unstable mod.test.ts",
     "deno:fmt": "deno fmt mod.ts && deno fmt mod.test.ts",
     "lint": "eslint . --fix",
-    "test:unit": "cross-env tape 'test/*-test.js' | tap-arc",
-    "coverage": "nyc --reporter=lcov --reporter=text-summary npm run test:unit",
-    "test:nolint": "npm run coverage",
+    "test:unit": "node --test",
+    "coverage": "node --test --experimental-test-coverage",
     "test": "npm run lint && npm run coverage",
     "rc": "npm version prerelease --preid RC",
     "build": "rollup -c",
     "vendor:js-yaml": "mkdir -p tmp && browserify --node --standalone js-yaml --im --no-builtins node_modules/js-yaml/index.js > tmp/js-yaml.js && mkdir -p src/compat/vendor && terser tmp/js-yaml.js -o src/compat/vendor/js-yaml.min.js",
     "vendor": "npm run vendor:js-yaml"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=20"
   },
   "repository": {
     "type": "git",
@@ -34,13 +33,9 @@
     "@rollup/plugin-json": "^6.0.0",
     "@rollup/plugin-terser": "~0.4.3",
     "browserify": "~17.0.0",
-    "cross-env": "~7.0.3",
     "eslint": "~9.1.1",
     "js-yaml": "~4.1.0",
-    "nyc": "^15.1.0",
     "rollup": "^3.27.0",
-    "tap-arc": "~1.2.2",
-    "tape": "~5.7.5",
     "terser": "~5.31.0"
   }
 }

readme.md

@@ -59,7 +59,7 @@ Parsing the file with the following code:
 ```javascript
 #!/usr/bin/env node
 const parse = require('@architect/parser')
-const fs = require('fs')
+const fs = require('node:fs')
 const text = fs.readFileSync('./some-arc-file.txt').toString()
 const result = parse(text)
 

test/00-lexer-test.js

@@ -1,4 +1,4 @@
-let test = require('tape')
+let test = require('node:test')
 let lex = require('../src/lexer')
 
 let arcfile = `
@@ -15,28 +15,24 @@ false false false
 # comment with spaces
 foo bar
 
-thing
-  nested thing
-  semi;colons
+#semi;colons?
 `
 
 test('lex', t => {
   t.plan(5)
 
   // can lex
-  t.ok(lex, 'exists')
+  t.assert.ok(lex, 'exists')
   let result = lex(arcfile)
 
   // got an array
-  t.ok(Array.isArray(result), 'lexed')
+  t.assert.ok(Array.isArray(result), 'lexed')
   let first = result[0]
   let second = result[1]
   let third = result[2]
 
   // ensure the arcfile parses as we'd expect
-  t.ok(first.type === 'newline' && first.line === 1 && first.column === 1, 'line 1 column 1 is a newline')
-  t.ok(second.type === 'newline' && second.line === 2 && first.column === 1, 'line 2 column 1 is a newline')
-  t.ok(third.type === 'pragma' && third.value === 'pragma1' && third.line === 3 && third.column === 1, 'hunp')
-
-  console.log(result)
+  t.assert.ok(first.type === 'newline' && first.line === 1 && first.column === 1, 'line 1 column 1 is a newline')
+  t.assert.ok(second.type === 'newline' && second.line === 2 && first.column === 1, 'line 2 column 1 is a newline')
+  t.assert.ok(third.type === 'pragma' && third.value === 'pragma1' && third.line === 3 && third.column === 1, 'hunp')
 })

test/01-ast-scalar-test.js

@@ -1,4 +1,4 @@
-let test = require('tape')
+let { test } = require('node:test')
 let parse = require('../')
 
 test('ast empty', t => {
@@ -32,8 +32,8 @@ test('ast empty', t => {
   }
 
   let parsed = parse.parser(parse.lexer(mock))
-  console.dir(parsed, { depth: null })
-  t.same(parsed, expected, 'successfully parsed ast for empty types')
+  // console.dir(parsed, { depth: null })
+  t.assert.deepEqual(parsed, expected, 'successfully parsed ast for empty types')
 })
 
 test('ast scalars', t => {
@@ -74,8 +74,8 @@ true`
   }
 
   let parsed = parse.parser(parse.lexer(mock))
-  console.dir(parsed, { depth: null })
-  t.same(parsed, expected, 'successfully parsed ast for scalar types')
+  // console.dir(parsed, { depth: null })
+  t.assert.deepEqual(parsed, expected, 'successfully parsed ast for scalar types')
 })
 
 test('ast arrays', t => {
@@ -127,6 +127,6 @@ one true 3 # comment2`
 
   let tokens = parse.lexer(mock)
   let parsed = parse.parser(tokens)
-  console.dir(parsed, { depth: null })
-  t.same(parsed, expected, 'successfully parsed array')
+  // console.dir(parsed, { depth: null })
+  t.assert.deepEqual(parsed, expected, 'successfully parsed array')
 })

test/02-ast-complex-test.js

@@ -1,4 +1,4 @@
-let test = require('tape')
+let { test } = require('node:test')
 let parse = require('../')
 let isVector = require('../src/parser/_is-vector')
 let isMap = require('../src/parser/_is-map')
@@ -15,7 +15,7 @@ vec   # hi
  some stuff here`
   let tokens = parse.lexer(mock)
   let start = tokens.slice(3, tokens.length) // start at 'vec'
-  t.ok(isVector(start), 'found a valid vector')
+  t.assert.ok(isVector(start), 'found a valid vector')
 })
 
 test('is not a vector', t => {
@@ -26,7 +26,7 @@ map
   one two`
   let tokens = parse.lexer(mock)
   let start = tokens.slice(3, tokens.length) // start at 'map' token
-  t.ok(isVector(start) === false, 'did not find a valid vector')
+  t.assert.ok(isVector(start) === false, 'did not find a valid vector')
 })
 
 test('ast vectors', t => {
@@ -106,8 +106,8 @@ this should be ignored`
     ],
   }
   let parsed = parse.parser(parse.lexer(mock))
-  console.dir(parsed, { depth: null })
-  t.same(parsed, expected, 'successfully parsed vector')
+  // console.dir(parsed, { depth: null })
+  t.assert.deepEqual(parsed, expected, 'successfully parsed vector')
 })
 
 test('isMap', t => {
@@ -123,8 +123,8 @@ map
   `
   let tokens = parse.lexer(mock)
   let start = tokens.slice(3, tokens.length)
-  console.log(start)
-  t.ok(isMap(start))
+  // console.log(start)
+  t.assert.ok(isMap(start))
 })
 
 test('map has three keys (vectors)', t => {
@@ -137,11 +137,11 @@ m1 # also cool
   three 3`
   let tokens = parse.lexer(mock)
   let ast = parse.parser(tokens)
-  console.dir(ast, { depth: null })
+  // console.dir(ast, { depth: null })
   let pragma = ast.values.find(t => t.type === 'pragma' && t.name === 'map-test')
   let map = pragma.values.find(t => t.type === 'map' && t.name === 'm1')
   let keys = map.values.filter(t => t.type === 'vector')
-  t.ok(keys.length === 3, 'has three keys')
+  t.assert.ok(keys.length === 3, 'has three keys')
 })
 
 test('map with vector', t => {
@@ -157,10 +157,10 @@ m1 #comment2
     false`
   let tokens = parse.lexer(mock)
   let mapTokens = tokens.slice(5, tokens.length)
-  t.ok(isVector(mapTokens) === false, 'isVector is false')
-  t.ok(isMap(mapTokens) === true, 'isMap is true')
-  let parsed = parse.parser(tokens)
-  console.dir(parsed, { depth: null })
+  t.assert.ok(isVector(mapTokens) === false, 'isVector is false')
+  t.assert.ok(isMap(mapTokens) === true, 'isMap is true')
+  /* let parsed = */parse.parser(tokens)
+  // console.dir(parsed, { depth: null })
 })
 
 test('map with scalars and vectors', t => {
@@ -185,7 +185,7 @@ m1 #comment2
   let map = pragma.values.find(t => t.type === 'map')
   let keys = map.values.filter( t => t.type === 'vector')
   let bools = keys.find(t => t.name === 'bools')
-  t.ok(keys.length === 4, 'has four keys')
-  t.ok(bools.values.filter(t => t.type === 'boolean').length === 2, 'bools has two booleans')
-  console.dir(parsed, { depth: null })
+  t.assert.ok(keys.length === 4, 'has four keys')
+  t.assert.ok(bools.values.filter(t => t.type === 'boolean').length === 2, 'bools has two booleans')
+  // console.dir(parsed, { depth: null })
 })