lib / main-config.sh: enable APA extension for questing and resolute builds

[leggewie]

alternative to #8966 to solve #8965 using APA for the latest Ubuntu releases

Summary by CodeRabbit

• New Features

  • APA extension now activates for more release types (broader release matching).

• Chores

  • Updated configuration to preserve existing architecture exclusions while expanding release matching.
  • Added notes for future follow-ups on default APA behavior and specific architecture handling.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

• Needs review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The PR changes the APA extension enablement check in lib/functions/configuration/main-config.sh to activate for releases matching sid, questing, or resolute (regex-based), preserves the loong64 exclusion, and adds two inline FIXME comments.

Changes

Cohort / File(s)	Change Summary
APA extension enablement change lib/functions/configuration/main-config.sh	Rewrote the condition to enable APA for releases matching the regex `sid

Sequence Diagram(s)

sequenceDiagram
    participant Script as main-config.sh
    participant Check as Release/Arch Check
    participant APA as APA enable flag

    rect rgba(200,240,200,0.2)
    Note left of Script: Old flow
    Script->>Check: is release == "sid"?
    alt release == sid and arch != loong64
        Check->>APA: enable APA
    else otherwise
        Check->>APA: do not enable
    end
    end

    rect rgba(200,220,240,0.2)
    Note left of Script: New flow
    Script->>Check: does release match /sid|questing|resolute/ ?
    alt matches and arch != loong64
        Check->>APA: enable APA
    else otherwise
        Check->>APA: do not enable
    end
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify the regex precisely matches intended release names and no unintended ones.
• Confirm the loong64 exclusion remains effective across code paths.
• Review the two FIXME comments for clarity and whether follow-up tasks are needed.

Possibly related PRs

• enable APA extension for Debian Unstable builds #8359 — Modifies APA extension activation logic in the same file; closely related change.
• K3: enable APA by default for Texas Instruments K3 family SBC #8331 — Adjusts where/when apa is enabled (adds APA for K3 family); configuration-level relation.
• extensions: add APA extension #8133 — Introduces APA extension implementation and related enablement/install logic.

Suggested reviewers

• rpardini
• igorpecovnik
• lanefu

Poem

🐇 I nudged the config with a tiny hop,

APA wakes for sid, questing, resolute — non-stop.
Loong64 waits outside the gate,
Two FIXME carrots mark the next update.
🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: enabling APA extension for questing and resolute builds in the main-config.sh file, which matches the file-level summary.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6a64c9a and 1f496db.

📒 Files selected for processing (1)

• lib/functions/configuration/main-config.sh (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: leggewie
Repo: armbian/build PR: 8559
File: config/desktop/sid/environments/kde-plasma:1-1
Timestamp: 2025-08-29T18:57:26.930Z
Learning: APA (Armbian Packaging Archive) is a project that focuses on defining package dependencies and will replace the aggregation part of the current build system, but not the entire build system. It is not a full replacement for desktop environment configuration approaches.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub API (https://api.github.com/repos/armbian/build/pulls/{pr_number}/files) to get the complete picture of what files are being added or modified, especially for U-Boot patches that will be applied during the build process.

Learnt from: glneo
Repo: armbian/build PR: 8913
File: config/sources/families/include/k3_common.inc:57-60
Timestamp: 2025-11-11T20:56:20.303Z
Learning: In config/sources/families/include/k3_common.inc, the OP-TEE build command at line 59 should be updated in a future PR to explicitly set CROSS_COMPILE64=aarch64-linux-gnu- and CROSS_COMPILE32=arm-linux-gnueabihf- instead of relying on OP-TEE's internal defaults, for better clarity and maintainability. User glneo agreed to address this in a separate PR.

Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-199
Timestamp: 2025-09-25T18:37:00.330Z
Learning: In PR armbian/build#8661, line 235 of lib/functions/compilation/armbian-kernel.sh already contains the corrected comment "BPF link support for netfilter hooks" for NETFILTER_BPF_LINK, not the misleading "BPF_SYSCALL" comment that was flagged during review.

Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-199
Timestamp: 2025-09-25T18:37:00.330Z
Learning: In PR armbian/build#8661, line 235 of lib/functions/compilation/armbian-kernel.sh already contains the corrected comment "BPF link support for netfilter hooks" for NETFILTER_BPF_LINK, not the misleading "BPF_SYSCALL" comment that was flagged during review.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.

Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-10-24T04:46:22.901Z
Learning: In lib/functions/rootfs/rootfs-create.sh, the FIXME comment about mmdebstrap usage with --aptopt is a future note related to PR #8785, which hasn't been merged yet.

📚 Learning: 2025-08-29T18:57:26.930Z

Learnt from: leggewie
Repo: armbian/build PR: 8559
File: config/desktop/sid/environments/kde-plasma:1-1
Timestamp: 2025-08-29T18:57:26.930Z
Learning: APA (Armbian Packaging Archive) is a project that focuses on defining package dependencies and will replace the aggregation part of the current build system, but not the entire build system. It is not a full replacement for desktop environment configuration approaches.

Applied to files:

• lib/functions/configuration/main-config.sh

📚 Learning: 2025-04-28T08:27:26.890Z

Learnt from: leggewie
Repo: armbian/build PR: 8133
File: extensions/apa.sh:1-2
Timestamp: 2025-04-28T08:27:26.890Z
Learning: In the Armbian build system, extension scripts in the `extensions/` directory contain hook functions and are meant to be sourced, not executed directly. These scripts don't require a shebang or `set -euo pipefail`.

Applied to files:

• lib/functions/configuration/main-config.sh

🧬 Code graph analysis (1)

lib/functions/configuration/main-config.sh (2)

lib/functions/general/extensions.sh (1)

• enable_extension (438-533)

extensions/apa.sh (2)

• extension_prepare_config__apa (3-6)
• post_armbian_repo_customize_image__install_from_apa (12-25)

🪛 GitHub Actions: Shellcheck - PR #8969 ("lib / main-config.sh: enable APA extension for questing and resolute builds")

lib/functions/configuration/main-config.sh

[error] 327-327: ShellCheck SC2074: Can't use =~ in [ ]. Use [[..]] instead. (lib/functions/configuration/main-config.sh:327)

[github-actions]

✅ This PR has been reviewed and approved — all set for merge!

[jhanmann]

Perhaps this wasn't expect to fix my original bug reported on trying to build questing kde-plasma. It doesn't appear to fix that in any case. I get the same errors about plasma-workspace-wayland and policykit1. The linkages in config for questing also appears to be broken in my view. The original 8966 that I tested worked but this one does not. Here are the linkages in config that I think are relevant to the problem:

ll config/desktop/noble/environments/
total 12K
lrwxrwxrwx 1 jon jon  34 Nov 19 07:56 cinnamon -> ../../common/environments/cinnamon
lrwxrwxrwx 1 jon jon  31 Nov 19 07:56 gnome -> ../../common/environments/gnome
drwxrwxr-x 1 jon jon  88 Nov 19 07:56 i3-wm
drwxrwxr-x 1 jon jon 102 Nov 19 07:56 kde-neon
lrwxrwxrwx 1 jon jon  35 Nov 19 07:56 kde-plasma -> ../../jammy/environments/kde-plasma
drwxrwxr-x 1 jon jon 106 Nov 19 07:56 xfce

[leggewie]

Perhaps this wasn't expect to fix my original bug reported on trying to build questing kde-plasma. It doesn't appear to fix that in any case. I get the same errors about plasma-workspace-wayland and policykit1. The linkages in config for questing also appears to be broken in my view. The original 8966 that I tested worked but this one does not.

Apologies for the late reply.

As I wrote elsewhere, it isn't really a surprise that more steps will need to be taken to completely fix this. You are welcome to use #8966 locally to do the things that you want to do right now. Nothing wrong with that at all. That is not the way forward for Armbian, though, as we try to retire that code base and switch to something more maintainable.