WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@schwar3kat
Copy link
Contributor

@schwar3kat schwar3kat commented Nov 24, 2025

Description

This board has no video out.
Add HAS_VIDEO_OUTPUT="no"

How Has This Been Tested?

  • Built Trixie image

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Chores
    • Updated board configuration to reflect video output capabilities for a specific hardware variant.

✏️ Tip: You can customize this high-level summary in your review settings.

This board has no video out.
Add HAS_VIDEO_OUTPUT="no"
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

Walkthrough

Added a new configuration variable HAS_VIDEO_OUTPUT set to "no" in the Radxa E52C board configuration file. This is a single-line addition to specify that the board does not have video output capability.

Changes

Cohort / File(s) Summary
Board configuration update
config/boards/radxa-e52c.conf
Added HAS_VIDEO_OUTPUT="no" configuration variable

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • amazingfate
  • leggewie
  • igorpecovnik

Poem

🐰 A config so neat, one line to add,
No video output here, but that's not bad!
Radxa E52C now knows the score,
Simple and clean, nothing more! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: adding HAS_VIDEO_OUTPUT="no" to radxa-e52c.conf. It accurately summarizes the specific modification made in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8a13522 and a2a68b9.

📒 Files selected for processing (1)
  • config/boards/radxa-e52c.conf (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-02T20:49:56.719Z
Learnt from: igorpecovnik
Repo: armbian/build PR: 8849
File: config/boards/radxa-e54c.csc:14-28
Timestamp: 2025-11-02T20:49:56.719Z
Learning: In Armbian board configuration files (config/boards/*.conf, *.csc, etc.), do not use kernel_config_set, kernel_config_set_m, kernel_config_set_y, or custom_kernel_config__* functions to modify kernel configuration. Kernel configuration is associated with LINUXFAMILY/BOARDFAMILY, not individual BOARD. Board-specific kernel modifications cause inconsistency in kernel packages published to the apt repository because boards within a family share the same kernel packages. Kernel configuration changes must be made in the appropriate kernel config file (e.g., config/kernel/linux-*-*.config) or in family configuration files (config/sources/families/*.conf, *.inc) instead.

Applied to files:

  • config/boards/radxa-e52c.conf
🔇 Additional comments (1)
config/boards/radxa-e52c.conf (1)

11-11: HAS_VIDEO_OUTPUT="no" is correctly added and properly formatted.

The variable is a recognized and documented Armbian configuration parameter that controls video output features and desktop environment builds. The value format matches all existing usage in the codebase, and the placement with other top-level config variables follows standard Armbian board configuration practices. No issues found.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 11 Milestone: Fourth quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Nov 24, 2025
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Nov 24, 2025
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Nov 24, 2025
@igorpecovnik igorpecovnik merged commit c84deb3 into armbian:main Nov 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants