WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit e651b50

Browse files
authored
Fix delete pin logic to remove credential 1st (#67)
1 parent c901fe3 commit e651b50

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

Authsignal.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = 'Authsignal'
3-
s.version = '2.2.2'
3+
s.version = '2.2.3'
44
s.summary = 'The Authsignal SDK for iOS'
55

66
s.homepage = 'https://github.com/authsignal/authsignal-ios'

Sources/Authsignal/AuthsignalInApp.swift

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,12 +181,16 @@ public class AuthsignalInApp {
181181
}
182182

183183
public func deletePin(username: String) async -> AuthsignalResponse<Bool> {
184-
pinManager.deletePin(username: username)
184+
let removeCredentialResponse = await removeCredential(username: username)
185185

186-
return await removeCredential(username: username)
186+
if removeCredentialResponse.error == nil, removeCredentialResponse.data == true {
187+
pinManager.deletePin(username: username)
188+
}
189+
190+
return removeCredentialResponse
187191
}
188192

189-
public func getAllUsernames() async -> AuthsignalResponse<[String]> {
193+
public func getAllPinUsernames() async -> AuthsignalResponse<[String]> {
190194
let usernames = pinManager.getAllUsernames()
191195

192196
return AuthsignalResponse(data: usernames)

0 commit comments

Comments
 (0)