guest_iommu_test: fix no bootable device issue for virtio_blk #4413

XueqiangWei · 2025-12-03T19:10:02Z

The bootindex will not be added to the virtio_blk device automatically after the new update (commit 9209b9482c984b3da752a2ab90c57a4af6254c0e). In order to avoid this issue, set image_boot=yes for virtio_blk device.

Signed-off-by: Xueqiang Wei [email protected]
ID: 4788

Summary by CodeRabbit

Chores
- Updated guest IOMMU test configuration to improve boot image handling during virtualization test execution, ensuring more reliable testing coverage.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

The bootindex will not be added to the virtio_blk device automatically after the new update (commit 9209b9482c984b3da752a2ab90c57a4af6254c0e). In order to avoid this issue, set image_boot=yes for virtio_blk device. Signed-off-by: Xueqiang Wei <[email protected]>

coderabbitai · 2025-12-03T19:10:22Z

Walkthrough

A single configuration property image_boot = yes was added to the virtio_blk section in the guest IOMMU test configuration file. This addition sets explicit boot image behavior during test execution without introducing any other functional modifications to the test suite.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This change requires minimal review effort:

Single property addition to an existing configuration block
No logic changes or complex interactions
No new files or removed entities
Configuration-only modification with straightforward verification

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding image_boot=yes to fix the bootable device issue for virtio_blk in guest_iommu_test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c94fef and 6f4b861.

📒 Files selected for processing (1)

qemu/tests/cfg/guest_iommu_test.cfg (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: JinLiul
Repo: autotest/tp-qemu PR: 4362
File: qemu/tests/cfg/sev_direct_kernel_boot.cfg:18-18
Timestamp: 2025-09-30T07:12:07.731Z
Learning: In QEMU SEV testing configurations, the vm_sev_kernel_hashes property works with both SEV and SNP variants as it was moved to common SevCommonProperties in recent QEMU patches, so it can be declared at the top level to apply to both variants.

📚 Learning: 2025-09-30T07:12:07.731Z

Learnt from: JinLiul
Repo: autotest/tp-qemu PR: 4362
File: qemu/tests/cfg/sev_direct_kernel_boot.cfg:18-18
Timestamp: 2025-09-30T07:12:07.731Z
Learning: In QEMU SEV testing configurations, the vm_sev_kernel_hashes property works with both SEV and SNP variants as it was moved to common SevCommonProperties in recent QEMU patches, so it can be declared at the top level to apply to both variants.

Applied to files:

qemu/tests/cfg/guest_iommu_test.cfg

🔇 Additional comments (1)

qemu/tests/cfg/guest_iommu_test.cfg (1)

13-16: Explicit image_boot on virtio_blk looks correct and scoped

Setting image_boot = yes under virtio_blk is consistent with the rest of the cfg (boolean style and indentation) and matches the PR goal of restoring a bootable virtio-blk root device after the upstream bootindex change. No additional issues from this change.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

XueqiangWei · 2025-12-03T19:13:15Z

The results passed.

(01/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_off.q35: STARTED
 (01/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_off.q35: PASS (85.98 s)
 (02/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_off.scenario1.q35: STARTED
 (02/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_off.scenario1.q35: PASS (116.15 s)
 (03/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_off.scenario2.q35: STARTED
 (03/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_off.scenario2.q35: PASS (116.70 s)
 (04/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_on.q35: STARTED
 (04/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_on.q35: PASS (111.88 s)
 (05/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_on.scenario1.q35: STARTED
 (05/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_on.scenario1.q35: PASS (111.65 s)
 (06/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_on.scenario2.q35: STARTED
 (06/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_on.scenario2.q35: PASS (81.08 s)
 (07/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.with_more_vcpus.q35: STARTED
 (07/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.with_more_vcpus.q35: PASS (115.44 s)
 (08/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.with_more_vcpus.scenario1.q35: STARTED
 (08/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.with_more_vcpus.scenario1.q35: PASS (116.36 s)
 (09/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.with_more_vcpus.scenario2.q35: STARTED
 (09/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.with_more_vcpus.scenario2.q35: PASS (81.51 s)
 (10/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.intremap_off.q35: STARTED
 (10/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.intremap_off.q35: PASS (109.81 s)
 (11/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.intremap_off.scenario1.q35: STARTED
 (11/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.intremap_off.scenario1.q35: PASS (110.32 s)
 (12/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.intremap_off.scenario2.q35: STARTED
 (12/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.intremap_off.scenario2.q35: PASS (81.11 s)
 (13/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.ats_off.q35: STARTED
 (13/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.ats_off.q35: PASS (110.16 s)
 (14/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.ats_off.scenario1.q35: STARTED
 (14/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.ats_off.scenario1.q35: PASS (111.75 s)
 (15/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.ats_off.scenario2.q35: STARTED
 (15/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.ats_off.scenario2.q35: PASS (81.24 s)
 (16/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.x2apic.q35: STARTED
 (16/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.x2apic.q35: PASS (111.99 s)
 (17/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.x2apic.scenario1.q35: STARTED
 (17/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.x2apic.scenario1.q35: PASS (111.88 s)
 (18/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.x2apic.scenario2.q35: STARTED
 (18/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.7.0.x86_64.io-github-autotest-qemu.guest_iommu_test.x2apic.scenario2.q35: PASS (80.80 s)
 (19/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_off.q35: STARTED
 (19/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_off.q35: PASS (203.14 s)
 (20/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_on.q35: STARTED
 (20/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.eim_on.q35: PASS (180.36 s)
 (21/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.with_more_vcpus.q35: STARTED
 (21/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.with_more_vcpus.q35: PASS (153.69 s)
 (22/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.intremap_off.q35: STARTED
 (22/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.intremap_off.q35: PASS (153.47 s)
 (23/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.ats_off.q35: STARTED
 (23/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.ats_off.q35: PASS (150.52 s)
 (24/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.x2apic.q35: STARTED
 (24/24) Host_RHEL.m9.u7.qcow2.virtio_blk.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.guest_iommu_test.x2apic.q35: PASS (151.81 s)

XueqiangWei · 2025-12-03T19:14:31Z

@zhencliu Could you please help review it? Many thanks.

XueqiangWei · 2025-12-04T08:43:59Z

Thanks Zhenchao.

zhencliu approved these changes Dec 4, 2025

View reviewed changes

XueqiangWei merged commit 6c8c63e into autotest:master Dec 4, 2025
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

guest_iommu_test: fix no bootable device issue for virtio_blk #4413

guest_iommu_test: fix no bootable device issue for virtio_blk #4413

Uh oh!

XueqiangWei commented Dec 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

XueqiangWei commented Dec 3, 2025

Uh oh!

XueqiangWei commented Dec 3, 2025

Uh oh!

XueqiangWei commented Dec 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

guest_iommu_test: fix no bootable device issue for virtio_blk #4413

guest_iommu_test: fix no bootable device issue for virtio_blk #4413

Uh oh!

Conversation

XueqiangWei commented Dec 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

XueqiangWei commented Dec 3, 2025

Uh oh!

XueqiangWei commented Dec 3, 2025

Uh oh!

XueqiangWei commented Dec 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

XueqiangWei commented Dec 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 3, 2025 •

edited

Loading