refactor: improve source selection and sidecar connection management #4554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement SidecarConnectionManager to handle metadata requests and connection state management - Enhance source selection handling with immediate feedback and proper error handling - Update SourceSelector to utilize the new connection manager for requesting metadata - Enhance MainPage to disable drive selection until full metadata is loaded - Improve error handling and connection management in SidecarConnectionManager and API module - Remove unnecessary console logs and improve error messages for better debugging - Enhance handling of pending requests to ensure robustness against multiple requests - Disable DriverlessDeviceAdapter on Windows to prevent WebSocket message handling issues in the sidecar process - Clean up legacy code related to spawning child processes and metadata requests - Ensure proper cleanup of selection state on errors during source selection
Contributor
|
A repository maintainer needs to approve these workflow run(s). To approve, maintainers can either: • Submit an approval review on this pull request, OR • Submit a review comment starting with Then re-run the failed job(s) via the Checks tab above. Reviews must be on the specific commit SHA of the workflow run to be considered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the source selection UX and refactors sidecar connection management for better reliability. It is a result of debugging issue #4537, to isolate the problem.
Changes
New Features
SidecarConnectionManagerclass: Centralizes sidecar process connection management with proper state handlingImprovements
CONNECTING,CONNECTED,FAILED,DISCONNECTED)File.pathtype issue in drag-and-drop handlerCode Quality
File.pathTypeScript issue)Files Changed
lib/gui/app/modules/sidecar-connection.ts(new)lib/gui/app/components/source-selector/source-selector.tsxlib/gui/app/models/selection-state.tslib/gui/app/models/store.tslib/gui/app/modules/api.tslib/gui/app/pages/main/MainPage.tsxlib/gui/app/app.tslib/util/api.tsTesting