WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Hermetic toolchain seems to pick up cc compiler executable but not flags #354

@calebzulawski

Description

@calebzulawski

This probably works in a lot of default cases, but not generally. For example, our compiler (portable_cc_toolchain) uses a sysroot that requires the flags --sysroot=path/to/sysroot --gcc-toolchain=path/to/gcc among a few other required linker flags. I think the correct implementation would use something like get_memory_inefficient_command_line for both compile and link actions, and add those flags via -Xcompiler and -Xlinker.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions