refactor: rename publish job to release-artifacts and restructure release process

Signed-off-by: Gordon Smith <[email protected]>

Author: GordonSmith

.github/workflows/release-please.yml

@@ -25,7 +25,7 @@ jobs:
           config-file: .github/release-please-config.json
           manifest-file: .github/release-please-manifest.json
 
-  publish:
+  release-artifacts:
     needs: [release-please]
     if: ${{ needs.release-please.outputs.release_created == 'true' }}
     runs-on: ubuntu-latest
@@ -49,24 +49,56 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: ${{ steps.event_details.outputs.tag_name }}
-      # Publishes to GitHub releases, VS Code Marketplace, and Open VSX Registry
-      # Requires secrets: PAT_VSCE (VS Code Marketplace) and OVSX_PAT (Open VSX)
-      - name: Add files and publish release
+      - name: Build VSIX and upload to release
         env:
           GITHUB_TOKEN: ${{ github.token }}
-          VSCE_PAT: ${{ secrets.PAT_VSCE }}
-          OVSX_PAT: ${{ secrets.OVSX_PAT }}
           TAG_NAME: ${{ steps.event_details.outputs.tag_name }}
         run: |
           npm ci
           npm run package
           mv wit-idl.vsix ${TAG_NAME}.vsix
           gh release upload ${TAG_NAME} ${TAG_NAME}.vsix
-          npx vsce publish --packagePath ${TAG_NAME}.vsix
-          npx ovsx publish ${TAG_NAME}.vsix -p ${OVSX_PAT}
+
+  publish-vsce:
+    needs: [release-please, release-artifacts]
+    if: ${{ needs.release-please.outputs.release_created == 'true' }}
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    steps:
+      - uses: actions/checkout@v4
+      - name: Download VSIX asset
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+          TAG_NAME: ${{ needs.release-artifacts.outputs.tag_name }}
+        run: gh release download ${TAG_NAME} --pattern "${TAG_NAME}.vsix"
+      - name: Publish to VS Code Marketplace
+        env:
+          VSCE_PAT: ${{ secrets.VSCE_PAT }}
+          TAG_NAME: ${{ needs.release-artifacts.outputs.tag_name }}
+        run: npx vsce publish --packagePath ${TAG_NAME}.vsix
+
+  publish-ovsx:
+    needs: [release-please, release-artifacts]
+    if: ${{ needs.release-please.outputs.release_created == 'true' }}
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    steps:
+      - uses: actions/checkout@v4
+      - name: Download VSIX asset
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+          TAG_NAME: ${{ needs.release-artifacts.outputs.tag_name }}
+        run: gh release download ${TAG_NAME} --pattern "${TAG_NAME}.vsix"
+      - name: Publish to Open VSX Registry
+        env:
+          OVSX_PAT: ${{ secrets.OVSX_PAT }}
+          TAG_NAME: ${{ needs.release-artifacts.outputs.tag_name }}
+        run: npx ovsx publish ${TAG_NAME}.vsix -p ${OVSX_PAT}
 
   label:
-    needs: [publish]
+    needs: [release-artifacts, publish-vsce, publish-ovsx]
     runs-on: ubuntu-latest
     permissions:
       contents: read
@@ -83,7 +115,7 @@ jobs:
           gh pr edit ${PR_NUMBER} --add-label 'autorelease: published'
 
   comments:
-    needs: [publish]
+    needs: [release-artifacts, publish-vsce, publish-ovsx]
     runs-on: ubuntu-latest
     permissions:
       contents: write
@@ -94,7 +126,7 @@ jobs:
         with:
           GITHUB_TOKEN: ${{ github.token }}
           comment-template: |
-            :tada: This change has been included in ${{ needs.publish.outputs.tag_name }} :tada:
+            :tada: This change has been included in ${{ needs.release-artifacts.outputs.tag_name }} :tada:
 
             The release is available on:
             - GitHub releases: {release_link}