caddyhttp: create a placeholder for and log ech status #7328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Nov 24, 2025
Member
There was a problem hiding this comment.
This LGTM -- my only other thought is should it just be called ech? Or, do we plan on expanding this later where we'll need an object to combine multiple ECH-related properties?
But, if we don't mind changing it later potentially, I am OK with this. Otherwise we should think about it a little more.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
francislavoie
changed the title
francislavoie
approved these changes
Dec 7, 2025
Co-authored-by: Francis Lavoie <[email protected]>
francislavoie
force-pushed
the
tls-ech-ph
branch
from
dff673b to
7c018c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 7326.
Also added ech status in the log.
Assistance Disclosure
No AI was used.