-
-
Notifications
You must be signed in to change notification settings - Fork 5
docs: use better examples + document cascade layers #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
+ general clean up of docs
sgoudham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a general comment, do we need to add all this documentation? Felt like the components on the current page gave a pretty decent overview of how the theme looked already.
Feels like a lot of duplication from Astro's own docs 🤔
I personally wouldn't see such a duplication as a bad thing, as the user can get the feel of the theme before actually using it. Alto I have to agree that it makes more sense if not only colors get adapted, but also eg border radius, margins, paddings and other positional modifications. For me there are basically two arguments for the more detailed pages:
But maybe you want to keep things minimalist here. I see a valid point in not including it, on the other hand, with the given advantages + already existing changes here, I don't see a huge benefit in not including it as I listed my points above... |
Yeah, the organisation's philosophy is to avoid changes outside of colours as much as possible, and for this theme specifically, the less tweaks the better.
I'd personally push back on this due to my statement above. We should stick to the defaults as much as possible, and only move away for adherence to the style guide. |
|
I reverted the example changes, just moved all docs to the root of |
Description
examples/with all possible Starlight componentsNote
Cascade layer docs depend on #50 to be merged before this PR