Fix incomplete change from "LVCF" back to "LOCF"

Author: lcbrooks

tests/testthat/test-compactify.R

@@ -22,52 +22,55 @@ row_replace <- function(dt,row,x,y) {
   dt
 }
 
+# Note that compactify is working on version-wise LOCF (last version of each
+# observation carried forward)
+
 # Rows 1 should not be eliminated even if NA
-dt <- row_replace(dt,1,NA,NA) # Not LVCF
+dt <- row_replace(dt,1,NA,NA) # Not LOCF
 
 # NOTE! We are assuming that there are no NA's in geo_value, time_value,
 # and version. Even though compactify may erroneously remove the first row
 # if it has all NA's, we are not testing this behaviour for now as this dataset
 # has problems beyond the scope of this test
 
 # Rows 11 and 12 correspond to different time_values
-dt <- row_replace(dt,12,11,11) # Not LVCF
+dt <- row_replace(dt,12,11,11) # Not LOCF
 
 # Rows 20 and 21 only differ in version
-dt <- row_replace(dt,21,20,20) # LVCF
+dt <- row_replace(dt,21,20,20) # LOCF
 
 # Rows 21 and 22 only differ in version
-dt <- row_replace(dt,22,20,20) # LVCF
+dt <- row_replace(dt,22,20,20) # LOCF
 
 # Row 39 comprises the first NA's
-dt <- row_replace(dt,39,NA,NA) # Not LVCF
+dt <- row_replace(dt,39,NA,NA) # Not LOCF
 
 # Row 40 has two NA's, just like its lag, row 39
-dt <- row_replace(dt,40,NA,NA) # LVCF
+dt <- row_replace(dt,40,NA,NA) # LOCF
 
 # Row 62's values already exist in row 15, but row 15 is not a preceding row
-dt <- row_replace(dt,62,15,15) # Not LVCF
+dt <- row_replace(dt,62,15,15) # Not LOCF
 
 # Row 73 only has one value carried over
-dt <- row_replace(dt,74,73,74) # Not LVCF
+dt <- row_replace(dt,74,73,74) # Not LOCF
 
 dt_true <- as_tibble(as_epi_archive(dt,compactify=TRUE)$DT)
 dt_false <- as_tibble(as_epi_archive(dt,compactify=FALSE)$DT)
 dt_null <- suppressWarnings(as_tibble(as_epi_archive(dt,compactify=NULL)$DT))
 
-test_that("Warning for LVCF with compactify as NULL", {
+test_that("Warning for LOCF with compactify as NULL", {
   expect_warning(as_epi_archive(dt,compactify=NULL))
 })
 
-test_that("No warning when there is no LVCF", {
+test_that("No warning when there is no LOCF", {
   expect_warning(as_epi_archive(dt[1:5],compactify=NULL),NA)
 })
 
-test_that("LVCF values are ignored with compactify=FALSE", {
+test_that("LOCF values are ignored with compactify=FALSE", {
   expect_identical(nrow(dt),nrow(dt_false))
 })
 
-test_that("LVCF values are taken out with compactify=TRUE", {
+test_that("LOCF values are taken out with compactify=TRUE", {
   dt_test <- as_tibble(as_epi_archive(dt[-c(21,22,40),],compactify=FALSE)$DT)
 
   expect_identical(dt_true,dt_null)
@@ -78,7 +81,7 @@ test_that("as_of produces the same results with compactify=TRUE as with compacti
   ea_true <- as_epi_archive(dt,compactify=TRUE)
   ea_false <- as_epi_archive(dt,compactify=FALSE)
 
-  # Row 22, an LVCF row corresponding to the latest version, is omitted in
+  # Row 22, an LOCF row corresponding to the latest version, is omitted in
   # ea_true
   latest_version = max(ea_false$DT$version)
   expect_warning({