WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Review and consider applying ?dplyr_extending for epi_df #223

@brookslogan

Description

@brookslogan

I believe that we implemented epi_df without the use of ?dplyr_extending. We may have:

  • Missing S3 implementations
  • Unnecessary S3 implementations
  • Noncompliant behavior

We should review ?dplyr_extending to see if it hints at bugs, enhancements, code simplifications, etc. (E.g., the mention of [ might have hinted that we would want a [ implementation before we discovered it on our own.)

Metadata

Metadata

Assignees

Labels

P2low prioritycleanupimprovements to developing&building experience&quality, not directly to built pkg&docs

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions