-
-
Notifications
You must be signed in to change notification settings - Fork 430
Description
We have
| action: cirun |
but it's not working for simply adding resources (e.g. the next-bigger one) to already existing policies (e.g. no PR to https://github.com/conda-forge/.cirun after #1746). In case the bot runs precommit before opening a PR, it's also very likely that the integration cannot handle the new linting I was asked to add in conda-forge/.cirun#116.
The integration was also not working for other resources already present for .cirun up until very recently (c.f. #1744), meaning this process was never used for anything related to cirun-azure-windows-{2xlarge,4xlarge} or cirun-macos-m4-large.
Overall, I think this is a bad fit for admin-requests (it also contributes to policies split by resource, which is problematic for actual feedstock maintenance), and we should simply handle this in https://github.com/conda-forge/.cirun directly.
The one thing worth keeping IMO is
admin-requests/examples/example-open-gpu-server.yml
Lines 14 to 15 in 07bcab9
| # Send an automatic PR to the feedstock to enable cirun defaults | |
| send_pr: true |
but I could imagine we could also trigger this from a reviewed and merged PR in https://github.com/conda-forge/.cirun if necessary.