WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

cirun integration isn't working well - handle in .cirun repo directly? #1749

@h-vetinari

Description

@h-vetinari

We have

but it's not working for simply adding resources (e.g. the next-bigger one) to already existing policies (e.g. no PR to https://github.com/conda-forge/.cirun after #1746). In case the bot runs precommit before opening a PR, it's also very likely that the integration cannot handle the new linting I was asked to add in conda-forge/.cirun#116.

The integration was also not working for other resources already present for .cirun up until very recently (c.f. #1744), meaning this process was never used for anything related to cirun-azure-windows-{2xlarge,4xlarge} or cirun-macos-m4-large.

Overall, I think this is a bad fit for admin-requests (it also contributes to policies split by resource, which is problematic for actual feedstock maintenance), and we should simply handle this in https://github.com/conda-forge/.cirun directly.

The one thing worth keeping IMO is

# Send an automatic PR to the feedstock to enable cirun defaults
send_pr: true

but I could imagine we could also trigger this from a reviewed and merged PR in https://github.com/conda-forge/.cirun if necessary.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions