WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Immy-delish
Copy link
Contributor

@Immy-delish Immy-delish commented Oct 10, 2024

Fixes

Description

This pull request Changes the Name of the Images attribution view and close Button when Attribution-Panel is expanded or closed

Technical details

Implemented the If Statements to check the status of the Attribution Panel to display the Naming the Button accordingly.

Screenshots

The Problem:
image

The Solution:
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Immy-delish Immy-delish requested review from a team as code owners October 10, 2024 01:22
@Immy-delish Immy-delish requested review from MuluhGodson, TimidRobot, nimishbongale and possumbilities and removed request for a team October 10, 2024 01:22
@netlify
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit 62c61bd
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/6713c2f020d61c0008854215
😎 Deploy Preview https://deploy-preview-162--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Immy-delish
Copy link
Contributor Author

Hello @possumbilities and @TimidRobot. Is This Change okay, The button only changes the text but not the color. Is it okay or it needs to be improved? Please let me know when you review. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

[Feature] Change button text when active or inactive.

1 participant