WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Allow minimumDaoBounty >= 0 #76

@dOrgJelli

Description

@dOrgJelli

Kei from Gnosis was interested in deploying a DAO with a minimumDaoBounty = 0, the voting machine configuration is pasted below. It seems strange that the smart contracts would prohibit this, and it should be something that's at the user's discretion to set properly as long as it's >= 0.

Requested Code Change:
require(_params[8] >= 0, "minimumDaoBounty should be >= 0");

Original Code:

require(_params[8] > 0, "minimumDaoBounty should be > 0");

Config:

{
  "queuedVoteRequiredPercentage": 20,
  "queuedVotePeriodLimit": 604800,
  "thresholdConst": 1001,
  "proposingRepReward": 10,
  "minimumDaoBounty": 0,
  "boostedVotePeriodLimit": 172800,
  "daoBountyConst": 3,
  "activationTime": 0,
  "preBoostedVotePeriodLimit": 43200,
  "quietEndingPeriod": 43200,
  "voteOnBehalf": "0x0000000000000000000000000000000000000000",
  "votersReputationLossRatio": 1
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions